Bug 1268450
Summary: | Review Request: rubygem-sidekiq - Simple, efficient background processing for Ruby | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ilia Gradina <ilya.gradina> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | package-review, pvalena |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2020-08-10 00:53:20 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1267328 | ||
Bug Blocks: | 201449 |
Description
Ilia Gradina
2015-10-02 20:48:03 UTC
pvalena's scratch build of rubygem-sidekiq-3.5.0-1.fc24.src.rpm for f24-candidate completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11757842 Informal Package Rewiew ======================= Issues ====== * I would change license in spec file from 'LGPL-3.0' to 'LGPLv3' according to [1]. * Packed in the gem, in file [2], there are bundled static libraries, which are forbidden according to [3]. The js libraries are also minified, which is also forbidden according to [4]. I think it is better to use 'js-jquery' rpm package instead. * In a file [5] are two licences before a minified code. I is better to have a single file for every CSS library. * There are also unsatisfied install dependencies: Last metadata expiration check performed 0:00:00 ago on Wed Nov 11 12:43:52 2015. No matching package to install: 'rubygem(celluloid)' No matching package to install: 'rubygem(connection_pool)' Not all dependencies satisfied Error: Some packages could not be found. These packages are not available in fedora rawhide. Note that 'rubygem-celluloid' is also orphaned. I would not approve this package, because the package fails to install. [1] https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing [2] ./web/assets/javascripts/application.js [3] https://fedoraproject.org/wiki/Packaging:JavaScript#Static_Inclusion_of_Libraries [4] https://fedoraproject.org/wiki/Packaging:JavaScript#Compilation.2FMinification [5] ./web/assets/stylesheets/bootstrap.css [6] https://bugzilla.redhat.com/show_bug.cgi?id=1239209 (In reply to Pavel Valena from comment #2) > These packages are not available in fedora rawhide. Note that > 'rubygem-celluloid' is also orphaned. Just FYI, rubygem-celluloid was orphaned and later retired for good reasons: https://lists.fedoraproject.org/pipermail/devel/2015-August/213660.html This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience. This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. |