Bug 1268612

Summary:	upgrade silently fails if /usr/bin/plymouth does not exist
Product:	[Fedora] Fedora	Reporter:	Jeff Raber <jeff.raber>
Component:	dnf-plugin-system-upgrade	Assignee:	Will Woods <wwoods>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	22	CC:	awilliam, fedora, jsedlak, robatino, wwoods, zbyszek
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	RejectedBlocker AcceptedFreezeException
Fixed In Version:	dnf-plugin-system-upgrade-0.7.0-1.fc23	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-11-02 18:52:32 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1170822

Description Jeff Raber 2015-10-03 15:53:09 UTC

Description of problem:
Tried to upgrade my F22 desktop to F23 beta using 'dnf system-upgrade download --releasever=23' and 'dnf system-upgrade reboot'.  After the reboot, nothing was installed.  The system just rebooted itself (no error message), and I was still running F22.

Version-Release number of selected component (if applicable):


How reproducible:
100% ?  I did it a couple of times on this machine.

Steps to Reproduce:
1. Install F22
2. Remove Plymouth
3. Try to update to F23 using dnf-plugin-system-upgrade

Actual results:
After reboot to apply upgrade, nothing is install and no error message is displayed.  System reboots and you're back in F22.

Expected results:
System is upgraded to F23, or at least an error message is given explaining that the upgarde failed for some reason.

Additional info:
Upstream Bug report: https://github.com/rpm-software-management/dnf-plugin-system-upgrade/issues/18
Upstream Patch: https://github.com/rpm-software-management/dnf-plugin-system-upgrade/commit/735d53a7126b4ae840cc574b72d6122a0b1c2c42

Comment 1 Jeff Raber 2015-10-03 16:07:20 UTC

Proposing this as Final blocker, as this bug makes the upgrade fail on a fully updated system (if that system doesn't have plymouth installed).  Also, it was already fixed upstream so it should be trivial to fix.  Or, if it's too late to fix, maybe we should add an explicit dependency on plymouth.

Comment 2 Adam Williamson 2015-10-05 22:28:56 UTC

Discussed at 2015-10-05 blocker review meeting: https://meetbot-raw.fedoraproject.org/fedora-blocker-review/2015-10-05/f23-blocker-review.2015-10-05-16.00.html . As this doesn't cause any kind of damage and is a fairly unusual configuration, we agreed it doesn't need to block the release, but obviously it'd be good to fix it. Was also accepted as a freeze exception issue, but obviously that only applies if a fix needs to go into the F23 package set.

Comment 3 Fedora Update System 2015-10-30 01:18:28 UTC

dnf-plugin-system-upgrade-0.7.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-69bef6b9ed

Comment 4 Jan Sedlák 2015-10-30 13:22:26 UTC

Seems fixed with newest dnf-plugin-system-upgrade.

Comment 5 Fedora Update System 2015-11-01 06:58:55 UTC

dnf-plugin-system-upgrade-0.7.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update dnf-plugin-system-upgrade'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-69bef6b9ed

Comment 6 Fedora Update System 2015-11-02 18:52:14 UTC

dnf-plugin-system-upgrade-0.7.0-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.