Bug 1268851
Summary: | libvirt on libxl passes "(null)" as a file when using a disk type=volume | ||
---|---|---|---|
Product: | [Community] Virtualization Tools | Reporter: | Nick L. <adamislife> |
Component: | libvirt | Assignee: | Libvirt Maintainers <libvirt-maint> |
Status: | CLOSED DEFERRED | QA Contact: | |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | unspecified | CC: | crobinso, jfehlig |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | x86_64 | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2020-11-03 17:12:40 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Nick L.
2015-10-05 13:02:45 UTC
Appears to still be relevant upstream. The function is: static int xenFormatXLDiskSrc(virStorageSourcePtr src, char **srcstr) { int actualType = virStorageSourceGetActualType(src); *srcstr = NULL; if (virStorageSourceIsEmpty(src)) return 0; switch ((virStorageType) actualType) { case VIR_STORAGE_TYPE_BLOCK: case VIR_STORAGE_TYPE_FILE: case VIR_STORAGE_TYPE_DIR: if (VIR_STRDUP(*srcstr, src->path) < 0) return -1; break; case VIR_STORAGE_TYPE_NETWORK: if (!(*srcstr = xenFormatXLDiskSrcNet(src))) return -1; break; case VIR_STORAGE_TYPE_VOLUME: case VIR_STORAGE_TYPE_NONE: case VIR_STORAGE_TYPE_LAST: break; } return 0; } Notice that STORAGE_TYPE_VOLUME just cleanly falls through. There isn't any explicit type=volume handling in the xl driver, so instead that case should throw an explicit error, until the code learns about TYPE_VOLUME CCing jfehlig Thank you for reporting this issue to the libvirt project. Unfortunately we have been unable to resolve this issue due to insufficient maintainer capacity and it will now be closed. This is not a reflection on the possible validity of the issue, merely the lack of resources to investigate and address it, for which we apologise. If you none the less feel the issue is still important, you may choose to report it again at the new project issue tracker https://gitlab.com/libvirt/libvirt/-/issues The project also welcomes contribution from anyone who believes they can provide a solution. |