Bug 1269217
| Summary: | FreeRADIUS triggers mprotect with large radius reply | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | dzr0001 | ||||
| Component: | freeradius | Assignee: | Nikolai Kondrashov <nikolai.kondrashov> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Jaroslav Aster <jaster> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | 7.1 | CC: | dpal, dzr0001, jnuckoll, pkis | ||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | x86_64 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2017-08-01 20:36:03 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 1202751 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
Hello DZR0001, Thank you for the report and sorry for the delay, we're just going around to handling FreeRADIUS bugs. Would it be possible for you to post the exact commands you've executed, or perhaps a script that produced these results? If not, could you please describe exactly what you mean by "request is too large"? Also, did you report this upstream, if yes, could you please provide a link? Thank you. Hi, A request that is "too large" is anything over 4096. I suspect this could be any garbage response. I've not reported this upstream. I build a test case with garbage data if that would be helpful. Understood. Yes, that would be most useful. Please post it if you can, please also add whatever server configuration is necessary to make it work. Thank you! I installed freeradius-3.0.4-6.el7.x86_64, admittedly on a centos machine. The only configuration change that I made was to add a user in /etc/raddb/users with the following configuration:
<user>
testuser Cleartext-Password := "t3stm3!"
Service-Type = Framed-User,
Framed-Protocol = PPP,
Reply-Message += "THIS IS A LONG TEST MESSAGE 0",
Reply-Message += "THIS IS A LONG TEST MESSAGE 1",
</user>
I increased the number of reply lines until I reached the 4096 limit. The behavior was as follows:
125 lines: works, response size was 4080
126-129 lines: errors: radclient: Received bad packet: Discarding packet: Larger than RFC limitation of 4096 bytes
130 lines: segfault with stack smashing error
I'll attach strace output from the segfaulted run.
Thanks.
Created attachment 1134610 [details]
Radiusd strace output
Thank you for the details, dzr0001. I found the problem in the code up to version 3.0.11. However, the latest code in the upstream v3.0.x branch has it fixed. I'll work on backporting the fix. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2017:1954 |
Description of problem: A radius request causes FreeRADIUS to die when the request is too large. Version-Release number of selected component (if applicable): freeradius-3.0.4-6.el7 How reproducible: 100% Steps to Reproduce: 1. Craft large radius reply 2. Request data that produces the large radius reply with radtest Actual results: <radtest> # radtest $username_redacted '$password_redacted' 127.0.0.1 1812 '$key_redacted' 0 127.0.0.1 Sending Access-Request Id 164 from 0.0.0.0:44127 to 127.0.0.1:1812 User-Name = '$username_redacted' User-Password = '$password_redacted' NAS-IP-Address = 127.0.0.1 NAS-Port = 1812 Message-Authenticator = 0x00 Sending Access-Request Id 164 from 0.0.0.0:44127 to 127.0.0.1:1812 User-Name = '$username_redacted' User-Password = '$password_redacted' NAS-IP-Address = 127.0.0.1 NAS-Port = 1812 Message-Authenticator = 0x00 Sending Access-Request Id 164 from 0.0.0.0:44127 to 127.0.0.1:1812 User-Name = '$username_redacted' User-Password = '$password_redacted' NAS-IP-Address = 127.0.0.1 NAS-Port = 1812 Message-Authenticator = 0x00 (0) No reply from server for ID 164 socket 3 </radtest> <strace> 11577 close(15) = 0 11577 munmap(0x7fca6f5d7000, 4096) = 0 11577 gettimeofday({1444148511, 7889}, NULL) = 0 11577 mprotect(0x7fca64023000, 4096, PROT_READ|PROT_WRITE) = 0 11577 open("/dev/tty", O_RDWR|O_NOCTTY|O_NONBLOCK) = -1 ENXIO (No such device or address) 11577 writev(2, [{"*** ", 4}, {"stack smashing detected", 23}, {" ***: ", 6}, {"/usr/sbin/radiusd", 17}, {" terminated\n", 12}], 5) = 62 11577 mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fca6f5d7000 11577 futex(0x7fca6d3b8d20, FUTEX_WAKE_PRIVATE, 2147483647) = 0 11577 --- SIGSEGV {si_signo=SIGSEGV, si_code=SI_KERNEL, si_addr=0} --- 11578 +++ killed by SIGSEGV +++ 11577 +++ killed by SIGSEGV +++ 11576 +++ killed by SIGSEGV +++ 11574 +++ killed by SIGSEGV +++ 11575 +++ killed by SIGSEGV +++ 11573 +++ killed by SIGSEGV +++ </strace> <log> # wc -l /var/log/radius/radacct/127.0.0.1/reply-detail-20151006 444 /var/log/radius/radacct/127.0.0.1/reply-detail-20151006 # ls -l /var/log/radius/radacct/127.0.0.1/reply-detail-20151006 -rw------- 1 root root 20706 Oct 6 11:21 /var/log/radius/radacct/127.0.0.1/reply-detail-20151006 # </log> Expected results: Return radius reply results. Additional info: Requests for this data on FreeBSD systems will simply return a truncated RADIUS reply rather than cause the daemon to crash.