Bug 1269535

Summary:	packstack script does not test to see if the rc files were created.
Product:	[Community] RDO	Reporter:	Stephen Wadeley <swadeley>
Component:	openstack-packstack	Assignee:	Ivan Chavero <ichavero>
Status:	CLOSED NOTABUG	QA Contact:	Shai Revivo <srevivo>
Severity:	low	Docs Contact:
Priority:	low
Version:	unspecified	CC:	aortega, chris.brown, derekh, ichavero, mmagr, srevivo
Target Milestone:	---	Keywords:	Reopened, RFE
Target Release:	Kilo
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-06-18 13:25:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Stephen Wadeley 2015-10-07 14:08:18 UTC

Description of problem:

The packstack script does not actually test to see if the rc files *were* created.

I ran `--allinone` and it had two errors at the end, but still printed out the message:
File /root/keystonerc_admin has been created on OpenStack client host 1.2.3.4

(where 1.2.3.4 is the IP address of my host)

yet I cannot find the file. 

Errors were:
ERROR : Error appeared during Puppet run: 1.2.3.4_prescript.pp
Error: Evaluation Error: Error while evaluating a Function Call, undefined method `unsafe_load_file' for Psych:Module

Version-Release number of selected component (if applicable):
~]# rpm -q openstack-packstack
openstack-packstack-2015.1-0.11.dev1616.g5526c38.fc23.noarch


Steps to Reproduce:
Make it fail, check for presence of keystonerc_admin

Actual results:

packstack prints out "File /root/keystonerc_admin has been created" even though it might not have been.

Expected results:
Script should not print messages that are assumptions.

Additional info:

 Martin Magr  explained:

Message is created and added to final messages when Puppet manifest is created. If packstack fails before the manifest is run, then file won't be created and message will still be printed.


Thank you

Comment 2 Chandan Kumar 2016-05-19 15:57:51 UTC

This bug is against a Version which has reached End of Life.
If it's still present in supported release (http://releases.openstack.org), please update Version and reopen.

Comment 3 Stephen Wadeley 2016-07-20 12:46:22 UTC

Hello

Has this been fixed?

Can we have a link to a git commit?


Thank you

Comment 4 Christopher Brown 2017-06-18 13:25:40 UTC

Hello,

If there were errors prior to final command I would not expect an rc file to be written. So I think this isn't really a bug as there are bigger problems to solve if the deployment doesn't work than not having a credentials file.