Bug 1269603
Summary: | Review Request: vim-commentary - Comment stuff out; takes a motion as a target | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Vít Ondruch <vondruch> |
Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | package-review, zbyszek |
Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | vim-commentary-1.2-1.fc24 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-12-02 09:55:36 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Vít Ondruch
2015-10-07 16:59:18 UTC
Please link to the raw spec file. Otherwise fedora-review doesn't work ootb. Yep, looks good. The %description is kind of hard to parse, but I don't use vim, maybe it would make sense if I did. I think you should change the Summary to be something like "Comment stuff out in vim using ...". - license is OK - license file is not present, but that's fine for a 35 line script that uses a common license :) - requires/provides are ok - appdata file is present, nice! - scriptlets are ok - latest version - fedora-review doesn't complain - rpmlint: vim-commentary.noarch: W: spelling-error %description -l en_US gcc -> cc, g cc vim-commentary.noarch: W: spelling-error %description -l en_US gc -> cg, g, c vim-commentary.noarch: W: spelling-error %description -l en_US gcap -> gap, cap, g cap All OK. vim-commentary.noarch: W: invalid-url URL: http://www.vim.org/scripts/script.php?script_id=3695 HTTP Error 503: Service Unavailable Works for me. Package is APPROVED. (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > Please link to the raw spec file. Otherwise fedora-review doesn't work ootb. Sorry, this was mistake on my side, since I typically do so > Yep, looks good. The %description is kind of hard to parse, but I don't use > vim, maybe it would make sense if I did. Well, yeah, I know, it could be better, but there is really nothing more to say (but suggestions are welcome :) > I think you should change the Summary to be something like "Comment stuff > out in vim using ...". I'll go with "Comment and uncomments stuff in Vim using motion as a target" > Package is APPROVED. Thanks for the review! Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/vim-commentary |