Bug 1270531
| Summary: | Review Request: gfeedline - Social Networking Client | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nuno Dias <nuno.dias> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | e, karlthered, package-review, samuel-rhbugs |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-03-25 10:37:24 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 177841 | ||
|
Description
Nuno Dias
2015-10-10 19:12:56 UTC
All of the following are blockers. * incorrect BuildRequires BuildRequires: python >= 2.6 Should be BuildRequires: python2-devel python-setuptools * Incorrect sources url, please read the following guideline https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Hosting_Services * Drop this include %include %{_rpmconfigdir}/macros.python * Do not use %py_libdir but %python2_sitelib * a lot of unowned directories, please read the following guidelines https://fedoraproject.org/wiki/Packaging:UnownedDirectories * No requires on runtime libraries, so your application will fail to run properly after installation. I think that most of your BuildRequires should be converted to Requires (after all, there is no test suite to run during package building) nunodias's scratch build of gfeedline-2.4.6-4.fc22.src.rpm for f22 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11410546 Haïkel, thanks for the advices. I addressed all the issues you mention, and created a new RPM, also build in koji. http://rpms.lip.pt/pub/f22/src/gfeedline-2.4.6-4.fc22.src.rpm http://rpms.lip.pt/pub/f22/src/gfeedline.spec nunodias's scratch build of gfeedline-2.4.6-5.fc22.src.rpm for f22 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11413320 A new minor version http://rpms.lip.pt/pub/f22/src/gfeedline-2.4.6-6.fc22.src.rpm http://rpms.lip.pt/pub/f22/src/gfeedline.spec nunodias's scratch build of gfeedline-2.4.6-7.fc22.src.rpm for f22 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11572371 |