Bug 1270769
Summary: | quota/marker: dir count in inode quota is not atomic | ||
---|---|---|---|
Product: | [Community] GlusterFS | Reporter: | Vijaikumar Mallikarjuna <vmallika> |
Component: | quota | Assignee: | Vijaikumar Mallikarjuna <vmallika> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 3.7.5 | CC: | bugs, gluster-bugs, smohan, storage-qa-internal |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | glusterfs-3.7.6 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | 1243798 | Environment: | |
Last Closed: | 2015-11-17 05:59:41 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1243797, 1243798 | ||
Bug Blocks: | 1275914 |
Comment 1
Vijay Bellur
2015-10-12 11:05:15 UTC
COMMIT: http://review.gluster.org/12341 committed in release-3.7 by Raghavendra G (rgowdapp) ------ commit 130190a3e1f2226883284aedbd63a9505fd0b702 Author: vmallika <vmallika> Date: Wed Oct 7 15:24:46 2015 +0530 quota/marker: dir_count accounting is not atomic This is a backport of http://review.gluster.org/#/c/11694/ Consider below scenario: Quota enabled on pre-existing data Now quota-crawl process will start healing xattrs Now if write is performed where healing is not complete, there is a possibility that 'update txn' is started before 'create xattr txn', in this case dir count can be missed on a dir where quota size xattr is not yet created. Solution is to get size xattr and if xattr is missing, add 1 for dir_count, this requires one additional fop if done in marker during each update iteration Better solution is to us xattrop GF_XATTROP_ADD_ARRAY64_WITH_DEFAULT > Change-Id: Idc8978860a3914e70c98f96effeff52e9a24e6ba > BUG: 1243798 > Signed-off-by: vmallika <vmallika> > Reviewed-on: http://review.gluster.org/11694 > Tested-by: NetBSD Build System <jenkins.org> > Reviewed-by: Raghavendra G <rgowdapp> Change-Id: If553372c31093d86fabe5a2ae5044a2cff28c3dc BUG: 1270769 Signed-off-by: vmallika <vmallika> Reviewed-on: http://review.gluster.org/12341 Tested-by: Gluster Build System <jenkins.com> Tested-by: NetBSD Build System <jenkins.org> Reviewed-by: Raghavendra G <rgowdapp> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.6, please open a new bug report. glusterfs-3.7.6 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://www.gluster.org/pipermail/gluster-users/2015-November/024359.html [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |