Bug 1271139

Summary: Review Request: perl-Fedora-VSP - Perl version normalization for RPM
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Fedora-VSP-0.001-1.fc24 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-10-13 13:05:13 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Petr Pisar 2015-10-13 08:50:49 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-Fedora-VSP/perl-Fedora-VSP.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Fedora-VSP/perl-Fedora-VSP-0.001-1.fc24.src.rpm
Description:
This module provides functions for normalizing Perl version strings for
Red Hat Package (RPM) based Linux distributions.

Fedora Account System Username: ppisar
Comment 1 Upstream Release Monitoring 2015-10-13 10:59:44 UTC 
jplesnik's scratch build of perl-Fedora-VSP-0.001-1.fc24.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11426513
Comment 2 Jitka Plesnikova 2015-10-13 11:04:24 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Fedora-VSP-0.001-1.fc24.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.22.0)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1

Binary requires are Ok.

$ rpm -qp --provides perl-Fedora-VSP-0.001-1.fc24.noarch.rpm | sort | uniq -c
      1 perl(Fedora::VSP) = 0.001
      1 perl-Fedora-VSP = 0.001-1.fc24

Binary provides are Ok.

$ rpmlint ./perl-Fedora-VSP*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Rpmlint is ok

FIX: Please add BRs 'findutils', 'coreutils' and 'make'

Otherwise package looks good.
Package APPROVED.
Comment 3 Petr Pisar 2015-10-13 13:05:13 UTC 
Thank you for the review. I added the three dependencies.