Bug 1271225

Summary:	x86_64: remove /usr/lib64/pm-utils/sleep.d/94cpufreq
Product:	[Fedora] Fedora	Reporter:	Prarit Bhargava <prarit>
Component:	pm-utils	Assignee:	Jaroslav Škarvada <jskarvad>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	21	CC:	jskarvad, pknirsch, rhughes
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	pm-utils-1.4.1-31.fc22	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-10-28 16:25:16 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Prarit Bhargava 2015-10-13 12:16:54 UTC

Description of problem: The /usr/lib64/pm-utils/sleep.d/94cpufreq is called when a user suspends and resumes their system. If the governor is in powersave mode from either the acpi-cpufreq or intel-pstate driver, the 94cpufreq code will switch the governor to performance and then suspend. On resume, the 94cpufreq code will switch the governor from performance back to powersave.

This extra transition in userspace continues to cause problems in the kernel space since the transition now has to be taken into account when modifying kernel code for the two drivers. The code has long been stable relative to suspend/resume and it is no longer necessary to perform this extra transition.

The 94cpufreq file can simply be dropped. It no longer serves any valid purpose.

Note that pm-utils has not been modified since 2010, and 94cpufreq has not been modified since 2008.

Version-Release number of selected component (if applicable): pm-utils-1.4.1-30.fc22.x86_64

How reproducible: 100%

Steps to Reproduce:
1. Suspend system with cpufreq governor in powersave
2. cpufreq governor will switch to performance
3. After resume, cpufreq governor will switch back to powersave

Actual results: Transition from powersave->performance (suspend/resume) performance->powersave

Expected results: No transition should occur.

Additional info: The acpi-cpufreq and intel-pstate drivers have worked properly with suspend/resume for a long time now. There are no known issues and RHEL7 has long worked with suspend/resume *without* pm-utils. Testing has been extensive across a large number of systems and no issues have been seen.

I have a feeling that 90clock and a few other files can also be removed (At least for 90clock I do know that the kernel includes a callback to sync the low res hardware clock before a suspend and after a resume.)

In any case, the code 94cpufreq is completely outdated and no longer necessary.

Comment 1 Jaroslav Škarvada 2015-10-13 13:11:58 UTC

Pm-utils was dropped. It is dead package since f23. But I can drop 94cpufreq from fedora<23 if needed.

Comment 2 Prarit Bhargava 2015-10-13 13:58:10 UTC

(In reply to Jaroslav Škarvada from comment #1)
> Pm-utils was dropped. It is dead package since f23. But I can drop 94cpufreq
> from fedora<23 if needed.

Jaroslav, I hate to ask (because this is probably something I should know ;)) ... what versions should I clone this bug to.  I think dropping 94cpufreq (and potentially 90clock) is something we should be doing.

P.

Comment 3 Jaroslav Škarvada 2015-10-13 14:20:27 UTC

(In reply to Prarit Bhargava from comment #2)
> (In reply to Jaroslav Škarvada from comment #1)
> > Pm-utils was dropped. It is dead package since f23. But I can drop 94cpufreq
> > from fedora<23 if needed.
> 
> Jaroslav, I hate to ask (because this is probably something I should know
> ;)) ... what versions should I clone this bug to.  I think dropping
> 94cpufreq (and potentially 90clock) is something we should be doing.
> 
> P.

NP, I will handle it in f21 - f22.

Comment 4 Fedora Update System 2015-10-13 16:24:49 UTC

pm-utils-1.4.1-31.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-ddee2bdec0

Comment 5 Fedora Update System 2015-10-13 16:25:45 UTC

pm-utils-1.4.1-31.fc21 has been submitted as an update to Fedora 21. https://bodhi.fedoraproject.org/updates/FEDORA-2015-f3431f59c9

Comment 6 Jaroslav Škarvada 2015-10-13 16:29:01 UTC

Dropped 94cpufreq hook in both f21, f22. Kept 90clock hook, because it is disabled by default. AFAIK the upstream project is dead for some time and the tool has been obsoleted by systemd/upower, etc. so it's probably all we can do here.

Comment 7 Fedora Update System 2015-10-14 08:54:20 UTC

pm-utils-1.4.1-31.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update pm-utils'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-f3431f59c9

Comment 8 Fedora Update System 2015-10-14 09:27:42 UTC

pm-utils-1.4.1-31.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update pm-utils'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-ddee2bdec0

Comment 9 Fedora Update System 2015-10-28 16:25:14 UTC

pm-utils-1.4.1-31.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.