Bug 1271785
Summary: | Review Request: nodejs-bcryptjs - bcrypt encryption for NodeJS | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jared Smith <jsmith.fedora> |
Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <zebob.m> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | package-review, piotr1212, zebob.m |
Target Milestone: | --- | Flags: | zebob.m:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-09-27 12:49:16 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1354009, 1354014, 1354016, 1354018 | ||
Bug Blocks: | 956806, 1387531 |
Description
Jared Smith
2015-10-14 17:49:49 UTC
I've only taken a quick look but it seems that the packaged files are generated/compiled. I think this should be built from source with closurecompiler. ok, closurecompiler is only needed for generating the minified js intended for browser use. You can skip that if you only intend to run it in nodejs. But you will have to use (and package) metascript to build the package.\ package.json: "build": "node scripts/build.js", https://github.com/dcodeIO/bcrypt.js/blob/master/scripts/build.js The %install section is missing some needed directories. Finnally making progress on this -- it's got a bunch of newer dependencies, but should be in much better shape now. Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-bcryptjs/nodejs-bcryptjs.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-bcryptjs/nodejs-bcryptjs-2.3.0-1.fc24.src.rpm Seems that the source has multiple licenses, they all need to be specified. dist dir needs to be installed. Binary as well. Not sure about externs dir. %build %nodejs_symlink_deps --check ^^ shouldn't this be --build %{?nodejs_find_provides_and_requires} %{!?_licensedir:%global license %doc} These macros are not needed anymore tests seem to be included in npm package now. Is the separate download still needed? Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-bcryptjs/nodejs-bcryptjs.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-bcryptjs/nodejs-bcryptjs-2.4.0-1.fc26.src.rpm Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-bcryptjs/nodejs-bcryptjs.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-bcryptjs/nodejs-bcryptjs-2.4.3-1.fc27.src.rpm Everything seems good, package accepted. 'Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/1596' (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-bcryptjs In rawhide, closing bug |