Bug 1272193
Summary: | ansible rpmlint errors | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> |
Component: | ansible | Assignee: | Kevin Fenzi <kevin> |
Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | 22 | CC: | a.badger, athmanem, j, kevin, kupo, maxim |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2016-07-19 19:58:03 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Orion Poplawski
2015-10-15 17:37:23 UTC
We could filter these out, but I am not sure if that will cause some issue. Also, we might want to check upstream the 2.0 version and get upstream to fix them before 2.0 comes out so we don't have to carry some mostly silly patch. Toshio: any thoughts? This message is a reminder that Fedora 21 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 21. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '21'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 21 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. I don't think we can fix this. * The most important problem is that ansible needs the shebangs in order to tell what sort of interpreter is needed to run the module. If it's #!/usr/bin/python then it will send it to the ansible_python_interpreter on the remote machine. If it's #!/bin/ruby, then ansible_ruby_interpreter would be used. So we definitely can't remove these. * Can we add the executable bit instead? We can but that isn't really making a "true" statement. These scripts aren't executable as is. Ansible needs to preprocess them to embed the module parameters and such before they'll run for real. So marking these executable causes no harm and gets rid of the rpmlint warnings but anyone trying to execute them directly will find that it doesn't actually work. My feeling is that we should probably ignore the rpmlint warnings in this case as that seems the most genuine. Was just pointed to this bug. The thing I don't completely understand is why these files are in with the actual python modules which are executed. Does something import them as regular python modules? If not, it seems to me that they're just data. And in that case, why aren't they stored in /usr/share/ansible or something? Yeah -- They may be able to go into /usr/share/ansible but you'd have to take a look at whether the ansible PluginLoader will actually find them from that location. They aren't imported by ansible on the controller so they don't need to be in %python_sitelib for that reason. You might have to do some patching to get it to recognize the new location or there might just be a config file option that you decide to change in the ansible.cfg that ships with Fedora. I can look at a patch if provided to see if it would be accepted upstream (I can't say either way at the moment. Upstream moved the modules from /usr/share/ansible into %python_sitelib just prior to my starting to work on ansible so there may be some resistance to shifting it back and forth but if it's configurable it seems like it could be accepted). If it's just a config file change, then simply carrying that downstream seems the easiest route. Fedora 22 changed to end-of-life (EOL) status on 2016-07-19. Fedora 22 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. |