Bug 1272301

Summary:	virsh client crash when pass an empty string to dump option format
Product:	Red Hat Enterprise Linux 7	Reporter:	Luyao Huang <lhuang>
Component:	libvirt	Assignee:	Peter Krempa <pkrempa>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	7.2	CC:	dyuan, fjin, mzhan, pkrempa, rbalakri, yafu
Target Milestone:	rc
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	libvirt-1.3.1-1.el7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-11-03 18:26:16 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Luyao Huang 2015-10-16 02:55:08 UTC

Description of problem:
virsh client crash when pass an empty string to dump option format

Version-Release number of selected component (if applicable):
libvirt-1.2.17-13.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1.prepare a running guest:
# virsh list --all
 Id    Name                           State
----------------------------------------------------
 2     rhel7.0-rhel                   running

2.
# virsh dump rhel7.0-rhel r7.dump --format '' --memory-only
Segmentation fault (core dumped)

3.

Actual results:
virsh get segfault

Expected results:

output error

Additional info:

Comment 1 Peter Krempa 2015-10-16 08:30:22 UTC

Fixed upstream:

commit 4ceaa7491e43b015bb2ea58c60aed889098e988d
Author: Peter Krempa <pkrempa>
Date:   Fri Oct 16 09:01:17 2015 +0200

    virsh: Use 'format' argument only when specified
    
    The condition checking whether --format was specified was incorrect.
    virsh crashed if the following format was used:
    
     virsh dump VM dump --format '' --memory-only

Comment 3 yafu 2016-02-26 06:06:49 UTC

Passed with version libvirt-1.3.1-1.el7.x86_64.

Steps:
1.Prepare a running guest:
  # virsh list --all
  Id    Name                           State
 ----------------------------------------------------
  1    rhel7.2                  running

2.virsh dump rhel7.2 /tmp/rhel72.dump --format '' --memory-only
  Domain rhel7.2 dumped to /tmp/rhel72.dump

3.Check the format of dump file:
  #file /tmp/rhel72.dump
  /tmp/rhel72.dump: ELF 64-bit LSB core file x86-64, version 1 (SYSV), SVR4-style

From the above steps, we can see when pass an empty string to dump option format, dump file can be generated with the default "ELF" format correctly.

Comment 4 yafu 2016-06-02 09:24:50 UTC

According to comment 3, move the bug to verified.

Comment 6 errata-xmlrpc 2016-11-03 18:26:16 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2577.html