Bug 1272524
| Summary: | Review Request: openstack-mistral - workflow Service for OpenStack cloud | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Community] RDO | Reporter: | Daniil <asteroid566> | ||||
| Component: | Package Review | Assignee: | hguemar | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | hguemar | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | Liberty | CC: | apevec, asteroid566, chris.brown, hguemar, jpena, lobo | ||||
| Target Milestone: | --- | Keywords: | Reopened | ||||
| Target Release: | trunk | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2017-06-18 07:03:30 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 1283327 | ||||||
| Bug Blocks: | 1243533 | ||||||
| Attachments: |
|
||||||
|
Description
Daniil
2015-10-16 15:57:03 UTC
Few comments:
* avoid using unversioned python macros
%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(1)")}
s/%{__python}/%{__python2}/
s/%{python_sitelib}/%{python2_sitelib}/
* cleaning buildroot is not required
rm -rf %{buildroot}
* Group tags are not used anymore, drop them
* RDO is not supporting anymore EL6, let's drop it.
Actually, EL6 has only python 2.6 which is not supported upstream.
* Please update the package to latest liberty release and add changelog, we'll adapt it to delorean later :)
* Short license name should be ASL 2.0
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing
* python-mistral should not own %{python_sitelib} directory, please name subdirectory.
I've posted an initial Delorean'ized version of the specs here: https://github.com/openstack-packages/mistral It builds but doesn't functionally work because our python2-yaql RPM is too old (it is at version 0.2 but 1.0.0 or greater is required). Also, I commented out the docs because we are missing a python-sphinxcontrib-pecanwsme as well for Delorean. Please include feedback in comment 1 and Dan's draft spec imported to openstack-packages/mistral and post updated spec. BTW, for Dan: initial import should be as submitted in the review i.e. import from https://github.com/mos-outside/mistral/tree/rpm-master then add your fixes on top of it, so it's easier to follow. I'll attach diff. Created attachment 1096550 [details]
Changes to openstack-mistral.spec from mos-outside/rpm-master
PING Hi, I think I addressed all Haikel and Alan comments. Please, check here SPEC and SRPM SPEC: https://mferminl.web.cern.ch/mferminl/fedorapkg/openstack-mistral/2.0.0/openstack-mistral.spec SRPM: https://mferminl.web.cern.ch/mferminl/fedorapkg/openstack-mistral/2.0.0/openstack-mistral-2.0.0-1.fc25.src.rpm - Python3 enabled - with_docs disabled due to we are waiting for BZ 1283327 (python-sphinxcontrib-pecanwsme). It will be ready soon. I don't have successful scratch due to there is no python-wsme library any more (http://pkgs.fedoraproject.org/cgit/rpms/python-wsme.git/tree/dead.package), and it is a mistral dependency https://github.com/openstack/mistral/blob/2.0.0/requirements.txt#L45. More info: https://koji.fedoraproject.org/koji/taskinfo?taskID=13743459 This bug is against a Version which has reached End of Life. If it's still present in supported release (http://releases.openstack.org), please update Version and reopen. This was closed by mitake using an automated script, reopening. This has landed so closing. |