Bug 1273334

Summary:	Fix in afr transaction code
Product:	[Community] GlusterFS	Reporter:	Ravishankar N <ravishankar>
Component:	replicate	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.6	CC:	bugs, gluster-bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1272362	Environment:
Last Closed:	2015-11-17 06:01:01 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1272362, 1275906
Bug Blocks:	1275914

Description Ravishankar N 2015-10-20 09:02:54 UTC

+++ This bug was initially created as a clone of Bug #1272362 +++

Description of problem:

Found while going through the code:

When winding the pre-op, transaction.pre_op[i] is set. If the pre-op fails,
transaction.failed_subvols[i] is set. If if fails on all chidren, we can
directly proceed to unlock (via afr_changelog_post_op_now) without trying
to wind the write, fail and then go to unlock.

--- Additional comment from Vijay Bellur on 2015-10-16 04:45:57 EDT ---

REVIEW: http://review.gluster.org/12368 (afr: do not wind write if pre-op fails on all children) posted (#1) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Vijay Bellur on 2015-10-20 04:44:40 EDT ---

COMMIT: http://review.gluster.org/12368 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 7945121dda340ec8f25711b2ad3ca70b544de967
Author: Ravishankar N <ravishankar>
Date:   Fri Oct 16 06:23:29 2015 +0530

    afr: do not wind write if pre-op fails on all children
    
    1. When winding the pre-op, transaction.pre_op[i] is set. If the pre-op fails,
    transaction.failed_subvols[i] is set. If if fails on all chidren, we can
    directly proceed to unlock (via afr_changelog_post_op_now) without trying
    to wind the write, fail and then go to unlock.
    
    2. 'fop_subvols' seems to be an unused variable, hence removing it.
    
    Change-Id: I9525628daf48082e979b0093fa0478934495e61f
    BUG: 1272362
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: http://review.gluster.org/12368
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Reviewed-by: Anuradha Talur <atalur>

Comment 1 Vijay Bellur 2015-10-20 09:08:28 UTC

REVIEW: http://review.gluster.org/12399 (afr: do not wind write if pre-op fails on all children) posted (#1) for review on release-3.7 by Ravishankar N (ravishankar)

Comment 2 Vijay Bellur 2015-10-26 08:50:02 UTC

REVIEW: http://review.gluster.org/12399 (afr: fixes in transaction code) posted (#2) for review on release-3.7 by Ravishankar N (ravishankar)

Comment 3 Vijay Bellur 2015-10-26 12:41:37 UTC

COMMIT: http://review.gluster.org/12399 committed in release-3.7 by Pranith Kumar Karampuri (pkarampu) 
------
commit da9f8bd6e9421209243afeabbad350cc1d70fdc5
Author: Ravishankar N <ravishankar>
Date:   Mon Oct 26 14:14:18 2015 +0530

    afr: fixes in transaction code
    
    Backport of http://review.gluster.org/#/c/12368/ and
    http://review.gluster.org/#/c/12415/
    
    1. When winding the pre-op, transaction.pre_op[i] is set. If the pre-op
    fails, transaction.failed_subvols[i] is set. If if fails on all chidren,
    we can directly proceed to unlock (via afr_changelog_post_op_now)
    without trying to wind the write, fail and then going to unlock.
    
    2. 'fop_subvols' seems to be an unused variable, hence removing it.
    
    3. Call local->transaction.wind() only on subvols where pre-op succeeded.
    
    Change-Id: I9525628daf48082e979b0093fa0478934495e61f
    BUG: 1273334
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: http://review.gluster.org/12399
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 4 Raghavendra Talur 2015-11-17 06:01:01 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.6, please open a new bug report.

glusterfs-3.7.6 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/gluster-users/2015-November/024359.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user