Bug 1273893

Lokesh, I sent you an updated spec file which required docker to be installed before the docker-selinux post gets executed.  Have you built a package for this in Fedora 23?

ohh I see I had only added it to master, added it now to f23 and will be fixed in docker-1.8.2-9.gitbdb52b6.fc23

docker-1.8.2-9.gitbdb52b6.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-334b8e444d

Thanks!  Is the new docker in some dnf repo somewhere so that I can test this easily?

docker-1.8.2-9.gitbdb52b6.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update docker'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-334b8e444d

docker-1.8.2-10.git28c300f.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-7e1a61e141

docker-1.8.2-10.git28c300f.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update docker'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-7e1a61e141

docker-1.8.2-10.git28c300f.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Still happens:

  Installing  : docker-selinux-1:1.8.2-10.git28c300f.fc23.x86_64        187/224 
restorecon:  lstat(/var/lib/docker) failed:  No such file or directory
warning: %post(docker-selinux-1:1.8.2-10.git28c300f.fc23.x86_64) scriptlet failed, exit status 255
  Installing  : docker-1:1.8.2-10.git28c300f.fc23.x86_64                188/224

I just built docker packages from source and I see the requires.

rpm -qpf /home/dwalsh/sources/RPMS/x86_64/docker-selinux-1.8.2-11.git28c300f.fc24.x86_64.rpm --requires
/bin/sh
/bin/sh
docker = 1:1.8.2-11.git28c300f.fc24
libselinux-utils
policycoreutils
policycoreutils-python-utils
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1
selinux-policy-base >= 3.13.1-119

So it is fixed is in that build.  I don't see this fix in docker-1.9.0-5.git11b81f9.fc24 rawhide

rpm -q docker-selinux
docker-selinux-1.9.0-5.git11b81f9.fc24.x86_64
rpm -q docker-selinux --requires | grep docker
[Exit 1]

I actually think the fix for this is to not require docker to be installed at all, we should just make the postinstall fail silently.  Since if docker-selinux is installed before docker, Which is should be, then rpm will automatically do the right thing as far as labeling.

Created attachment 1092854 [details]
Patch to fail silently on restorecon in post install

Also remove requirement for docker to be installed first.

(In reply to Daniel Walsh from comment #11)
> I actually think the fix for this is to not require docker to be installed
> at all, we should just make the postinstall fail silently.  Since if
> docker-selinux is installed before docker, Which is should be, then rpm will
> automatically do the right thing as far as labeling.

Yes, unlike for docker-selinux-1:1.8.2-7.gitcb216be.fc23.x86_64, this time around docker did actually work, regardless of the error.

I have a new build here: http://koji.fedoraproject.org/koji/taskinfo?taskID=11805530 , but fedpkg update seems to crap out saying invalid koji build, guess i'll retry submitting it in a bit