Bug 1274100
| Summary: | need a way to pause/stop tiering to take snapshot | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Dan Lambright <dlambrig> |
| Component: | tiering | Assignee: | bugs <bugs> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | bugs <bugs> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 3.7.6 | CC: | bugs, rjoseph, vagarwal |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.7.7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1267950 | Environment: | |
| Last Closed: | 2016-02-15 08:38:40 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1267950, 1274334 | ||
| Bug Blocks: | 1260923 | ||
|
Description
Dan Lambright
2015-10-21 23:02:38 UTC
REVIEW: http://review.gluster.org/13078 (cluster/tier: do not block in synctask created from pause tier) posted (#1) for review on release-3.7 by Dan Lambright (dlambrig) COMMIT: http://review.gluster.org/13078 committed in release-3.7 by Dan Lambright (dlambrig) ------ commit 4ec0e36fff703d156c52bada758b97eff86ce61c Author: Dan Lambright <dlambrig> Date: Wed Dec 16 15:28:57 2015 -0500 cluster/tier: do not block in synctask created from pause tier We had run sleep() in the pause tier callback. Blocking within a synctask is dangerous. The sleep() call does not inform the synctask scheduler that a thread is no longer running. It therefore believes it is running. If a second synctask already exists, it may not be able to run. This occurs if the thread limit in the pool has been reached. Note the pool size only grows when a synctask is created, not when it is moved from wait state to run state, as is the case when an FOP completes. When the tier is paused during migration, synctasks already exist waiting for responses to FOPs to the server with high probability. The fix is to yield() in the RPC callback, which will place the synctask into the wait queue and free up a thread for the FOP callback. A timer wakes the callback after sufficient time has elapsed for the pause to occur. This is a backport of 12987. > Change-Id: I6a947ee04c6e5649946cb6d8207ba17263a67fc6 > BUG: 1267950 > Signed-off-by: Dan Lambright <dlambrig> > Reviewed-on: http://review.gluster.org/12987 > Tested-by: Gluster Build System <jenkins.com> > Reviewed-by: Rajesh Joseph <rjoseph> Signed-off-by: Dan Lambright <dlambrig> Change-Id: I9bb7564d57d59abb98e89c8d54c8b1ff4a5fc3f3 BUG: 1274100 Reviewed-on: http://review.gluster.org/13078 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Dan Lambright <dlambrig> Tested-by: Dan Lambright <dlambrig> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.7, please open a new bug report. glusterfs-3.7.7 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://www.gluster.org/pipermail/gluster-users/2016-February/025292.html [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |