Bug 1274857
| Summary: | nntpsend doesn't work -- innxmit processes get killed before they are finished | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora EPEL | Reporter: | Jonathan Kamens <jik> | ||||
| Component: | inn | Assignee: | Dominik 'Rathann' Mierzejewski <dominik> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | epel7 | CC: | dominik, jik, jochen, n.pajkovsky, ovasik | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | inn-2.6.0-4.fc24 inn-2.6.0-4.fc23 inn-2.5.5-1.el7 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2016-07-10 05:55:50 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
FYI, the INN maintainers say, "Well, many thanks for your comments and the fix. Very much appreciated. It will be included in the next release (INN 2.6.1)." Could you test this scratch build once it completes? http://koji.fedoraproject.org/koji/taskinfo?taskID=12639955 Can't unfortunately unless you do a rebuild of suck as well:
Error: Package: suck-4.3.2-39.el7.x86_64 (@epel)
Requires: libinn.so.2()(64bit)
Removing: inn-libs-2.5.3-18.el7.x86_64 (@epel)
libinn.so.2()(64bit)
Updated By: inn-libs-2.6.0-1.el7.x86_64 (/inn-libs-2.6.0-1.el7.x86_6\
4)
~libinn.so.3()(64bit)
inn-2.5.5-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-b4ead6ec2a inn-2.6.0-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3c83d0c73d inn-2.6.0-4.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-594d7ca809 inn-2.5.5-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-b4ead6ec2a inn-2.6.0-4.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-594d7ca809 inn-2.6.0-4.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-3c83d0c73d inn-2.6.0-4.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. inn-2.6.0-4.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. inn-2.5.5-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 1085870 [details] nntpsend patch When systemd runs the innd-nntpsend service, the innxmit processes that get launched by nntpsend get killed by systemd before they are finished. Here's why... The documentation for nntpsend claims that it waits until all of the child innxmit processes exit before it does, but it doesn't. The reason it does not is because it starts the innxmit processes, or more accurately the subshells that start the innxmit processes, in a while loop that is itself in a child process of the main shell, because of this line: cat ${INPUT} | while read SITE HOST SIZE_ARG FLAGS; do Since the while loop is in a pipe, it's executed in a child process. As a result, its child processes, i.e., the ones running innxmit, are not direct children of the nntpsend shell script's process, so it doesn't wait for them. A trivial fix is attached. (Also submitted to the INN maintainers, but given that this bug makes nntpsend completely note work on RHEL, I advise patching it in RHEL quickly rather than waiting for the upstream maintainers to put out a new release with the fix.)