Bug 1275552

Summary: [hosted-engine] Disk actions on Hosted-engine storage domain should warn the user or possible risks.
Product: [oVirt] ovirt-engine Reporter: Elad <ebenahar>
Component: BLL.StorageAssignee: Martin Sivák <msivak>
Status: CLOSED WONTFIX QA Contact: Elad <ebenahar>
Severity: high Docs Contact:
Priority: medium    
Version: 3.6.0CC: alukiano, bugs, dfediuck, didi, ebenahar, lveyde, mgoldboi, michal.skrivanek, nsednev, rmartins, sbonazzo, stirabos, ylavi
Target Milestone: ---Keywords: Reopened
Target Release: ---Flags: sbonazzo: ovirt-4.2-
Hardware: x86_64   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1444671 (view as bug list) Environment:
Last Closed: 2017-05-14 14:21:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: SLA RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1444671    

Description Elad 2015-10-27 08:41:51 UTC
Description of problem:
3.6 Hosted-engine deployment involves the import of the hosted-engine storage domain. This exposure the HE domain to changes. For example, disks creation on this domain is allowed.

Version-Release number of selected component (if applicable):
ovirt-hosted-engine-setup-1.3.0-1.el7ev.noarch
rhevm-3.6.0.2-0.1.el6.noarch


How reproducible:
Always

Steps to Reproduce:
1. Deploy hosted-engine (hosted-engine deployment supposed to involve the HE SD import on 3.6 late builds. Import the domain manually if it doesn't)
2. Attempt to create disks on the domain


Actual results:
Disks creation is allowed. This can cause to a situation in which the domain space gets filled. 

Expected results:
Operations like disks creation on the hosted-engine storage domain should not be allowed

Comment 1 Martin Sivák 2015-10-29 09:53:33 UTC
I believe this belongs to the ovirt-engine component.

Comment 2 Roy Golan 2016-01-13 09:52:48 UTC
Moran I don't want to devel ack that before we understand if we want to block that.

Comment 3 Roy Golan 2016-01-13 13:43:48 UTC

*** This bug has been marked as a duplicate of bug 1290478 ***

Comment 4 Elad 2016-01-21 12:48:00 UTC
Roy, there are several scenarios that IMO must be blocked or at least raise a warning.

For example:
- Disk creation/copy on/to the HE storage domain
- Storage domain creation out of HE SD LUN (in case it's block storage)
- Storage domain import using HE SD LUN (in case it's block storage)


Anyway, this bug is not a DUP of 1290478 since 1290478 addresses actions on the HE VM and here we are talking about the HE SD.

Comment 5 Moran Goldboim 2016-01-25 12:31:12 UTC
(In reply to Roy Golan from comment #2)
> Moran I don't want to devel ack that before we understand if we want to
> block that.

I think that Elad is pointing out the fact that the HE storage domain is not anyhow limited in the system and as an example you can create regular vm images on top of it. which shouldn't be the case and it should handle only the HE vm images.

Elad, anything i missed?

Comment 6 Roy Golan 2016-02-24 10:32:05 UTC
That is a case we may want it to be configurable because it may depend on the size and complexity of your deployment.

Comment 7 Elad 2016-03-06 11:57:26 UTC
(In reply to Moran Goldboim from comment #5)
> (In reply to Roy Golan from comment #2)
> > Moran I don't want to devel ack that before we understand if we want to
> > block that.
> 
> I think that Elad is pointing out the fact that the HE storage domain is not
> anyhow limited in the system and as an example you can create regular vm
> images on top of it. which shouldn't be the case and it should handle only
> the HE vm images.
> 
> Elad, anything i missed?

That's exactly my point here

Comment 8 Nikolai Sednev 2016-03-06 12:23:08 UTC
HE-SD should not be exposed within the engine as Date domain. Creation of additional disks on HE-SD should not be allowed. Customer can easily create VMs with disks on HE-
sd, which will degrade the HE's overall availability and performance.

Any additionally created disks on HE-SD should be exposed only to HE-VM.

Comment 9 Yaniv Lavi 2016-03-06 12:48:35 UTC
(In reply to Nikolai Sednev from comment #8)
> HE-SD should not be exposed within the engine as Date domain. Creation of
> additional disks on HE-SD should not be allowed. Customer can easily create
> VMs with disks on HE-
> sd, which will degrade the HE's overall availability and performance.
> 
> Any additionally created disks on HE-SD should be exposed only to HE-VM.

I don't agree, it's up to customer and we can provide a best practice, but no more than that.
Any reason that running vm on the same storage can cause issues with HA?

> - Storage domain creation out of HE SD LUN (in case it's block storage)

What is the diff from regular SD?

> - Storage domain import using HE SD LUN (in case it's block storage)

What is the diff from regular SD?

Comment 10 Elad 2016-03-06 13:09:38 UTC
> > - Storage domain creation out of HE SD LUN (in case it's block storage)
> 
> What is the diff from regular SD?
In 3.6, first DC initialization triggers the hosted-engine storage domain to be imported to this DC. The problem is that this first DC initialization can be done by creating the first data domain out of the hosted-engine storage domain's LUN in case it is block storage (in case of a file storage, an attempt to create a domain on a path that has a domain on it, is blocked on CDA).

> 
> > - Storage domain import using HE SD LUN (in case it's block storage)
> 
> What is the diff from regular SD?
If the first DC is initialized by importing a data domain to the DC, and this domain is the hosted-engine one, the DC won't initialize since the hosted-engine storage domain cannot take master role (https://bugzilla.redhat.com/show_bug.cgi?id=1315074)

Comment 11 Doron Fediuck 2017-03-13 15:25:31 UTC
*** Bug 1431677 has been marked as a duplicate of this bug. ***

Comment 12 Yaniv Lavi 2017-05-14 14:21:41 UTC
We plan to make the HE SD a normal SD in the system, consideration on workloads being used on this SD will be added to the docs.