Bug 127627

Summary:	Apparent typo in /etc/init.d/pcmcia prevents modules unloading, hence laptop suspend
Product:	[Fedora] Fedora	Reporter:	James Turner <jturner>
Component:	pcmcia-cs	Assignee:	Dave Jones <davej>
Status:	CLOSED ERRATA	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	2	CC:	barryn, jar, notting, pfrields
Target Milestone:	---
Target Release:	---
Hardware:	i386
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2004-10-11 18:57:01 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description James Turner 2004-07-11 15:10:49 UTC

Description of problem:

When executing "/etc/init.d/pcmcia stop", the yenta_socket (etc.) 
module does not get unloaded, apparently due to a typo. My IBM T22 
laptop won't go into suspend with this module loaded, so I have to 
do "rmmod yenta_socket" manually as root before suspend will work, 
even though I listed pcmcia as a service to be restarted by apmd 
in /etc/sysconfig/apmd.

The problem is in the statement:

  if grep -q "ds  " /proc/modules ; then

The grep never matches because there are 2 spaces after "ds", whereas 
there is only one space after "ds" in /proc/modules.

If I edit the pcmcia script to remove the extra space from the
first grep argument (ie. "ds "), then "/etc/init.d/pcmcia stop" now 
works correctly and my laptop is put into suspend automatically by 
apmd when I close the lid.

(By the way, ACPI suspend doesn't work for me on this machine)


Version-Release number of selected component (if applicable):

initscripts-7.53-1

How reproducible:
Every time

Steps to Reproduce:
1. su
2. /etc/init.d/pcmcia stop
3. /sbin/lsmod
  
Actual results:
The modules "yenta_socket" and "ds" are still loaded.

Expected results:
The modules should have been unloaded.

Additional info:
I'm running Fedora Core 2 final with kernel 2.6.5 on an IBM Thinkpad 
T22 laptop with a Pentium III processor (just in case 
the /proc/modules format varies between kernels or systems...).

Comment 1 Bill Nottingham 2004-09-08 05:35:15 UTC

*** Bug 127774 has been marked as a duplicate of this bug. ***

Comment 2 Bill Nottingham 2004-09-08 06:11:56 UTC

Please try pcmcia-cs-3.2.7-1.8.2.1 in FC2 test updates.

Comment 3 James Turner 2004-10-11 17:14:32 UTC

Thanks for the fix. Unfortunately my laptop's motherboard died just
days before your reply(!), so I can't try out the update on the
original computer... The problem should be generic enough to test on
another machine though(?) - when my new T42 laptop arrives, I'll
install FC3 and check that it's now OK.

Comment 4 Bill Nottingham 2004-10-11 18:57:01 UTC

Closing as fixed in the update.