Bug 1276280

Summary: Checksum error on metadata read if PV created with inappropriate pvcreate options
Product: [Fedora] Fedora Reporter: Peter Rajnoha <prajnoha>
Component: lvm2Assignee: Peter Rajnoha <prajnoha>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: agk, bmarzins, bmr, dwysocha, heinzm, jonathan, lvm-team, msnitzer, prajnoha, prockai, zkabelac
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: lvm2-2.02.133-1.fc24 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-10-30 16:02:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Peter Rajnoha 2015-10-29 10:41:53 UTC 
Actual results:
# pvcreate --dataalignment 1k --metadatasize 1k /dev/sda
  Physical volume "/dev/sda" successfully created

# vgcreate vg /dev/sda
  Volume group "vg" successfully created

# pvs
  /dev/sda: Checksum error
  Couldn't read volume group metadata.
  /dev/sda: Checksum error
  Couldn't read volume group metadata.
  /dev/sda: Checksum error
  Couldn't read volume group metadata.
  PV         VG     Fmt  Attr PSize   PFree  
  /dev/sda          lvm2 ---  128.00m 128.00m
  /dev/vda2  fedora lvm2 a--   19.49g      0 

# lvm version
  LVM version:     2.02.133(2)-git (2015-09-22)
  Library version: 1.02.110-git (2015-09-22)
  Driver version:  4.33.0

Expected results:
vgcreate should stop creating the VG on a PV with inappropriate properties if it would lead to checksum error later on.
Comment 1 Peter Rajnoha 2015-10-29 15:53:14 UTC 
Patch:

https://git.fedorahosted.org/cgit/lvm2.git/commit/?id=00348c0a630a7e5578edf48052ec695b15de752f

Also, this patch makes this situation much less probable:
https://git.fedorahosted.org/cgit/lvm2.git/commit/?id=ccb8da404d00288b7d49c7a28006ec5d4687bb55
Comment 2 Peter Rajnoha 2015-10-30 11:23:43 UTC 
Better check:

https://git.fedorahosted.org/cgit/lvm2.git/commit/?id=c2e88d1107c496d2c1b39bbbfb9795e88b3a6b60