Bug 1276901

can you take this for me https://bugzilla.redhat.com/show_bug.cgi?id=1266804 ?

know the meaning of Spec URL and SRPM URL ? why I do not know what to make of these references you provided ...

Please, remove "rm -rf $RPM_BUILD_ROOT" from install section

It could be that you're not part of the packaging group?

Other issues:
%doc %{_datadir}/man/man1/%{name}.1.gz
%doc %{_datadir}/pixmaps/
%doc /usr/bin/%{name} 
please, remove %doc macro and use %{_bindir}/%{name}

(In reply to gil cattaneo from comment #4)
> It could be that you're not part of the packaging group?

true I'm not, I need a sponsor for the package and myself. 
I'm willing to spend a lot of time and effort in learning the right way to do this packaging. :)

I didn't quite understand what you meant by not making sense on the urls and such
but now I'm connecting the two and deducing you meant to question why they are that way.

(In reply to PeteV from comment #6)
> (In reply to gil cattaneo from comment #4)
> > It could be that you're not part of the packaging group?
> 
> true I'm not, I need a sponsor for the package and myself. 
> I'm willing to spend a lot of time and effort in learning the right way to
> do this packaging. :)

Please, read
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group
https://fedoraproject.org/wiki/Package_Review_Process

> I didn't quite understand what you meant by not making sense on the urls and
> such
> but now I'm connecting the two and deducing you meant to question why they
> are that way.

I leave this bug to others, who could become your sponsor (i cant help you in this)

Ok Gil thanks have a great day!

Hey!

It's better to provide direct-download urls for reviewers, so fedora-review-tool can pick-up the files directly.  =)

e.g. like this:

Spec URL: https://raw.githubusercontent.com/PeteV/RPM-Repo/master/xoscope.spec
SRPM URL: https://github.com/PeteV/RPM-Repo/raw/master/xoscope-2.1-1.fc22.x86_64.rpm

* * *

Taking this.

Spec URL: https://raw.githubusercontent.com/PeteV/RPM-Repo/master/xoscope.spec
SRPM URL: https://raw.githubusercontent.com/PeteV/RPM-Repo/master/xoscope-2.1-1.fc22.x86_64.rpm

* * *

github-urls corrected

Spec URL: https://raw.githubusercontent.com/PeteV/RPM-Repo/master/xoscope.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/petev/xoscope/fedora-rawhide-x86_64/00131632-xoscope/xoscope-2.1-1.fc24.src.rpm
* * *

srpm-url corrected

Thanks Björn, much to learn.....

(In reply to Björn "besser82" Esser from comment #11)
> Spec URL:
> https://raw.githubusercontent.com/PeteV/RPM-Repo/master/xoscope.spec
> SRPM URL:
> https://copr-be.cloud.fedoraproject.org/results/petev/xoscope/fedora-rawhide-
> x86_64/00131632-xoscope/xoscope-2.1-1.fc24.src.rpm
> * * *
> 
> srpm-url corrected

thanks again Björn, I made some changes to the spec file and rebuild on copr
if you could do a quick check that will be great :)

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

This is an automatic action taken by review-stats script.

The ticket reviewer failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we reset the status and the assignee of this ticket.

If you still want include this package, please update links to working spec and srpm archive. And update to latest upstream version available. If not, please close the review.

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.