Bug 1276933

Summary:	Review Request: python-cycler - Cycle through lists in various ways (used by matplotlib) required for matplotlib-1.5
Product:	[Fedora] Fedora	Reporter:	Neal Becker <ndbecker2>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, tomspur, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+ ndbecker2: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-11-09 19:57:05 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Neal Becker 2015-11-01 14:20:00 UTC

Spec URL: https://nbecker.fedorapeople.org/python-cycler.spec
SRPM URL: https://nbecker.fedorapeople.org/python-cycler-0.9.0-1.fc22.src.rpm
Description: General purpose library used by matplotlib to cycle through lists for colors, marker styles, etc
Fedora Account System Username: nbecker

Comment 1 Zbigniew Jędrzejewski-Szmek 2015-11-01 20:19:11 UTC

Source0 is in URL.

"Requires: six" is in the generic section, but you probably want it in the python2 package section.

Use %license for LICENSE [https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text].

You can put the Summary in the generic section, and the refer to the text as %{summary} in the python2- and python3- section. This will save one define.

The description should be line-wrapped.

Comment 2 Zbigniew Jędrzejewski-Szmek 2015-11-01 20:21:07 UTC

Also, you need Requires: python3-six for the python3 package.

Comment 3 Upstream Release Monitoring 2015-11-04 17:01:52 UTC

nbecker's scratch build of python-cycler-0.9.0-1.fc23.src.rpm for f23 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11702392

Comment 4 Upstream Release Monitoring 2015-11-04 18:24:33 UTC

nbecker's scratch build of python-cycler-0.9.0-1.fc23.src.rpm for f23 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11703148

Comment 5 Upstream Release Monitoring 2015-11-04 18:29:55 UTC

nbecker's scratch build of python-cycler-0.9.0-2.fc23.src.rpm for f23 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11703218

Comment 6 Upstream Release Monitoring 2015-11-04 18:34:12 UTC

nbecker's scratch build of python-cycler-0.9.0-3.fc23.src.rpm for f23 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11703244

Comment 7 Zbigniew Jędrzejewski-Szmek 2015-11-05 13:15:49 UTC

Is this last rebuild something to review again? Can you post the updated .spec file in that case?

Comment 8 Neal Becker 2015-11-05 13:41:38 UTC

Still working on it.

rpmlint found 1 issue (need to fix LICENSE)

Comment 9 Neal Becker 2015-11-06 16:42:17 UTC

OK, I think it's ready

Spec URL: https://nbecker.fedorapeople.org/python-cycler.spec
SRPM URL: https://nbecker.fedorapeople.org/python-cycler-0.9.0-4.fc23.src.rpm

Comment 10 Zbigniew Jędrzejewski-Szmek 2015-11-07 11:09:12 UTC

Everything looks good. rpmlint only has false positives about spelling.

Package is APPROVED.

Comment 11 Gwyn Ciesla 2015-11-08 16:26:49 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-cycler