Bug 1276939

Summary:	[AAA] ovirt-engine-role.sh fixups
Product:	[oVirt] ovirt-engine	Reporter:	Alon Bar-Lev <alonbl>
Component:	AAA	Assignee:	Alon Bar-Lev <alonbl>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Ondra Machacek <omachace>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.5.0	CC:	alonbl, bugs, ecohen, gklein, iheim, lsurette, oourfali, pstehlik, rbalakri, yeylon, ylavi
Target Milestone:	ovirt-3.5.6	Keywords:	CodeChange
Target Release:	3.5.6	Flags:	ylavi: ovirt-3.5.z? rule-engine: planning_ack? alonbl: devel_ack+ pnovotny: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	infra
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1262604	Environment:
Last Closed:	2015-12-22 13:25:14 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Infra	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1262604
Bug Blocks:

Description Alon Bar-Lev 2015-11-01 15:01:46 UTC

+++ This bug was initially created as a clone of Bug #1262604 +++

CURRENT BEHAVIOUR

# PGPASSWORD=xxx psql -h localhost -U engine -d engine -c 'select domain, external_id from users;'
     domain     |             external_id              
----------------+--------------------------------------
 internal-authz | ae93e5fd-9f3b-4392-8eff-f09ebe12b9f1

#  /usr/share/ovirt-engine/bin/ovirt-engine-role.sh --command=add --user-name=admin --provider=internal-authz1234 --provider-id=ae93e5fd-9f3b-4392-8eff-f09ebe12b9f1 --role=SuperUser

# PGPASSWORD=UJHJLSDjr7MAlIQiaebBSs psql -h localhost -U engine -d engine -c 'select domain, external_id from users;'     domain     |             external_id              
----------------+--------------------------------------
 internal-authz | ae93e5fd-9f3b-4392-8eff-f09ebe12b9f1

EXPECTED BEHAVIOUR

The user from internal-authz1234 should be added, even if the provider-id is the same as other providers, uniqueness is per provider.

--- Additional comment from Alon Bar-Lev on 2015-09-13 07:11:20 EDT ---

1. provider id should be unique within provider.
2. namespace is missing
3. parameter do not confirm to other product terms.

--- Additional comment from Red Hat Bugzilla Rules Engine on 2015-10-18 04:21:45 EDT ---

Fixed bug tickets must have version flags set prior to fixing them. Please set the correct version flags and move the bugs back to the previous status after this is corrected.

--- Additional comment from Eyal Edri on 2015-11-01 09:25:17 EST ---

this bug has both 3.5.z & 3.6.0 flags, in bugzilla lang it means its a clone candidate from 3.6.0 to 3.5.z meaning it's pending a clone and wasn't fixed for 3.5.z.

if this isn't the case, please fix flags accordingly,
if it is the case, then please clone the bugs to 3.5.7 (3.5.6 was built already)

Comment 1 Red Hat Bugzilla Rules Engine 2015-11-01 15:01:55 UTC

Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 2 Ondra Machacek 2015-11-03 12:28:55 UTC

Usage: /usr/share/ovirt-engine/bin/ovirt-engine-role.sh [OPTIONS]

    --authz-name=name        Name of authorization provider instace.
    --principal-namespace=ns Namespace within provider.
    --principal-id=id        Unique user id within provider.

Comment 3 Sandro Bonazzola 2015-12-22 13:25:14 UTC

oVirt 3.5.6 has been released and the bz verified, moving to closed current release.