Bug 1277487 (kukulich/fshl)
| Summary: | Review Request: php-kukulich-fshl - FSHL: fast syntax highlighter | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> | ||||||||
| Component: | Package Review | Assignee: | Shawn Iwinski <shawn> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | rawhide | CC: | package-review, shawn | ||||||||
| Target Milestone: | --- | Flags: | shawn:
fedora-review+
|
||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2015-11-16 23:24:16 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 1277504 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Remi Collet
2015-11-03 13:05:14 UTC
Minor fix Spec: https://raw.githubusercontent.com/remicollet/remirepo/cc031b9ccee0a497d233ce6fea274e5fce9df778/php/php-kukulich-fshl/php-kukulich-fshl.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-kukulich-fshl-2.1.0-1.remi.src.rpm Created attachment 1089157 [details]
phpcompatinfo-full.log
phpCompatInfo version 4.5.1 DB built Oct 11 2015 19:58:20 CEST
Created attachment 1089158 [details]
phpcompatinfo-lib.log
phpCompatInfo version 4.5.1 DB built Oct 11 2015 19:58:20 CEST
Created attachment 1089159 [details]
fedora-review.txt
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1277487
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
[!]: Buildroot is not present
Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but not required
As usual, remove EPEL 5 bits after initial import. Not a blocker.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v2 or later)", "Unknown or generated", "GPL (v2 or later)
(with incorrect FSF address)", "*No copyright* GPL (v2 or later)",
"GPL (v2)", "*No copyright* Apache (v2.0)". 75 files have unknown
license.
Library is GPLv2+ not MIT.
In tests there are also some Apache, BSD, GPL, and MIT licenced files
though.
Good catch (too much copy/paste... too much "new packages ;) https://github.com/remicollet/remirepo/commit/2c32ecb8d421f34bd191c200077a19e1aeb9520f Spec: https://raw.githubusercontent.com/remicollet/remirepo/2c32ecb8d421f34bd191c200077a19e1aeb9520f/php/php-kukulich-fshl/php-kukulich-fshl.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-kukulich-fshl-2.1.0-2.remi.src.rpm [x]: License field in the package spec file matches the actual license. No blockers. ===== APPROVED ===== Thanks! SCM request awaiting review on pkgdb2 Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/php-kukulich-fshl php-kukulich-fshl-2.1.0-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-ae698b70d4 php-kukulich-fshl-2.1.0-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-4e5f130916 php-kukulich-fshl-2.1.0-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-5fe6f73ce1 php-kukulich-fshl-2.1.0-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update php-kukulich-fshl' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-ae698b70d4 php-kukulich-fshl-2.1.0-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update php-kukulich-fshl' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-5fe6f73ce1 php-kukulich-fshl-2.1.0-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update php-kukulich-fshl' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-3eca48bc1e php-kukulich-fshl-2.1.0-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update php-kukulich-fshl' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-4e5f130916 php-kukulich-fshl-2.1.0-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. php-kukulich-fshl-2.1.0-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. php-kukulich-fshl-2.1.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. php-kukulich-fshl-2.1.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |