Bug 1277550

Summary: Failback should be provided the the macro _pkgdocdir
Product: [Fedora] Fedora Reporter: Mohammad Alhashash <alhashash>
Component: gitAssignee: Petr Stodulka <pstodulk>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: chrisw, jbowes, pstodulk, tmz
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-11-03 16:26:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Mohammad Alhashash 2015-11-03 14:35:52 UTC 
The spec file has references the macro _pkgdocdir which is not defined for older fedora versions. In line:

rm -f %{buildroot}%{_pkgdocdir}/git-subtree.html

This should be either replaced with:

rm -f %{buildroot}%{?_pkgdocdir}%{!?_pkgdocdir:%{_docdir}/%{name}-%{version}}/git-subtree.html

As done in other place or the macro could be defined globally using:

%{!?_pkgdocdir: %global _pkgdocdir %{_docdir}/%{name}-%{version}}

This would allow building the package on earlier Fedora releases.

See: https://fedoraproject.org/wiki/Changes/UnversionedDocdirs
Comment 1 Petr Stodulka 2015-11-03 16:26:13 UTC 
Good catch! Thanks for report.