Bug 1278128

Summary:	quick installer clobbers existing "OPTIONS" field
Product:	OpenShift Container Platform	Reporter:	Erik M Jacobs <ejacobs>
Component:	Installer	Assignee:	Scott Dodson <sdodson>
Status:	CLOSED WONTFIX	QA Contact:	Xiaoli Tian <xtian>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	3.1.0	CC:	aos-bugs, bleanhar, jokerman, mmccomas
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-08-24 20:50:15 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Erik M Jacobs 2015-11-04 17:32:21 UTC

When you have various things in the /etc/sysconfig/docker file OPTIONS line.

For example, if you start with:

OPTIONS='--selinux-enabled --insecure-registry foofoofoo --insecure-registry barbarbar'

These options are clobbered/lost and only the registry service IP and etc. ends up being there.

There is a workaround by moving these into the "ADD_REGISTRY" line, but that's not intuitive...

Comment 2 Jason DeTiberus 2015-11-04 17:57:17 UTC

For the most part, this is working as intended.

We should better document how to set the various registry settings in the advanced docs, and rely on ansible to handle that config.  There are other docker options that we are setting that would make parsing the existing settings and modifying them a bit difficult (ensuring selinux is set properly, and the log driver options we currently support).

and we would also need to add support for setting these options in the quick installer.

That said...  We should not be setting --insecure-registry={{ openshift.node.portal_net }} in that file, since we now provide instructions on how to create a secure registry.

I also do not see an issue with adding support for appending arbitrary docker options as well.

I'm going to go ahead and mark this as UpcomingRelease though, since I do not believe