Bug 1278411

Summary: RHOS 6 needs to be PEP8 valid
Product: Red Hat OpenStack Reporter: Sahid Ferdjaoui <sferdjao>
Component: openstack-novaAssignee: Sahid Ferdjaoui <sferdjao>
Status: CLOSED ERRATA QA Contact: nlevinki <nlevinki>
Severity: low Docs Contact:
Priority: low    
Version: 6.0 (Juno)CC: berrange, dasmith, eglynn, kchamart, mbooth, ndipanov, sbauza, sferdjao, sgordon, slong, vromanso, yeylon
Target Milestone: ---Keywords: OtherQA, Triaged, ZStream
Target Release: 6.0 (Juno)   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: openstack-nova-2014.2.3-38.el7ost Doc Type: Bug Fix
Doc Text:
Previously, OpenStack Compute did not conform to PEP8 conventions; this has been fixed.
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-01-07 20:50:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Sahid Ferdjaoui 2015-11-05 12:17:01 UTC
Code needs to be pep8 valid.

Running flake8 ...
./nova/tests/db/test_db_api.py:293:1: E302 expected 2 blank lines, found 1
./nova/tests/objects/test_compute_node.py:25:1: F401 'hardware' imported but unused
./nova/tests/objects/test_pci_device.py:232:1: E302 expected 2 blank lines, found 1
./nova/tests/scheduler/test_host_filters.py:2130:80: E501 line too long (80 > 79 characters)
./nova/tests/scheduler/test_host_manager.py:29:1: H306  imports not in alphabetical order (nova.openstack.common.timeutils, nova.objects)
./nova/tests/virt/libvirt/fake_libvirt_utils.py:197:1: E302 expected 2 blank lines, found 1
./nova/tests/virt/libvirt/fake_libvirt_utils.py:201:1: E302 expected 2 blank lines, found 1
./nova/tests/virt/libvirt/test_driver.py:1432:9: F841 local variable 'image_meta' is assigned to but never used
./nova/tests/virt/libvirt/test_driver.py:12400:9: F841 local variable 'out' is assigned to but never used
./nova/scheduler/utils.py:244:1: E302 expected 2 blank lines, found 1
./nova/scheduler/client/__init__.py:20:1: H307  like imports should be grouped together (nova.openstack.common.importutils and nova.scheduler.utils from project are separated by whitespace)
./nova/virt/block_device.py:285:38: F821 undefined name '_LW'
./nova/virt/disk/vfs/guestfs.py:17:1: H307  like imports should be grouped together (eventlet.tpool and oslo.config.cfg from third-party are separated by whitespace)
./nova/virt/libvirt/driver.py:1769:17: F821 undefined name 'image_service'
./nova/virt/libvirt/driver.py:1808:52: E241 multiple spaces after ','
./nova/virt/libvirt/driver.py:3207:80: E501 line too long (81 > 79 characters)
./nova/virt/libvirt/host.py:36:1: E302 expected 2 blank lines, found 1
./nova/virt/libvirt/imagebackend.py:783:26: E203 whitespace before ':'

Comment 5 errata-xmlrpc 2016-01-07 20:50:03 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-0013.html