Bug 1278459

Summary: WebUI:VMRC:Linux:Firefox - "SyntaxError: expected expression, got '&'" when accessing the vmrc console
Product: Red Hat CloudForms Management Engine Reporter: Ramesh A <rananda>
Component: UI - OPSAssignee: Martin Hradil <mhradil>
Status: CLOSED ERRATA QA Contact: Ramesh A <rananda>
Severity: high Docs Contact:
Priority: high    
Version: 5.5.0CC: hkataria, jhardy, mpovolny, obarenbo, simaishi
Target Milestone: GA   
Target Release: 5.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.5.0.11 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-12-08 13:44:42 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
FF-Linux none

Description Ramesh A 2015-11-05 14:33:27 UTC
Created attachment 1090117 [details]
FF-Linux

Description of problem:
"SyntaxError: expected expression, got '&'" when accessing the vmrc console (in the web console) and UI displays as "The Remote Console is connecting" for ever in firefox browser (38.0.5) in the linux machines

Version-Release number of selected component (if applicable):
5.5.0.9-beta2.20151102161742_5530c9a

How reproducible:
100%

Steps to Reproduce:
1. Deploy an appliance
2. Manage v55
3. Navigate to Infrastructure ==> Virtual Machines ==> Select an virtual machine and click on the vmrc link

Actual results:
Displays "SyntaxError: expected expression, got '&'" in the web console.  Refer the screenshot for further details

Expected results:
Should display the vmrc console

Additional info:

Comment 2 Martin Povolny 2015-11-09 13:38:43 UTC
the bug is here:

    $(vmrc).height($(window).height() - ($(&quot;#container&quot;).offset().top + 10));

Comment 5 CFME Bot 2015-11-09 15:15:33 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/1df8c02e5d68dd91d63208e993e628dad72a6052

commit 1df8c02e5d68dd91d63208e993e628dad72a6052
Author:     Martin Hradil <mhradil>
AuthorDate: Mon Nov 9 13:55:09 2015 +0000
Commit:     Martin Hradil <mhradil>
CommitDate: Mon Nov 9 13:57:29 2015 +0000

    console_vmrc - fix erb conversion - bad escaping and misplaced else
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1278459

 app/views/vm_common/console_vmrc.html.haml | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comment 7 CFME Bot 2015-11-12 20:32:04 UTC
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=1b85879d89cd366be59be9e965ef46a9e166a848

commit 1b85879d89cd366be59be9e965ef46a9e166a848
Author:     Martin Hradil <mhradil>
AuthorDate: Mon Nov 9 13:55:09 2015 +0000
Commit:     Martin Hradil <mhradil>
CommitDate: Wed Nov 11 16:10:28 2015 +0000

    console_vmrc - fix erb conversion - bad escaping and misplaced else
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1278459
    (cherry picked from commit 1df8c02e5d68dd91d63208e993e628dad72a6052)

 app/views/vm_common/console_vmrc.html.haml | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comment 8 CFME Bot 2015-11-12 20:32:40 UTC
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=fec3d10849a43548231c4b4b04550bf1b11f3d5d

commit fec3d10849a43548231c4b4b04550bf1b11f3d5d
Merge: fa2e637 1b85879
Author:     Dan Clarizio <dclarizi>
AuthorDate: Wed Nov 11 13:22:52 2015 -0500
Commit:     Dan Clarizio <dclarizi>
CommitDate: Wed Nov 11 13:22:52 2015 -0500

    Merge branch 'console-vmrc-55' into '5.5.z'
    
    console_vmrc - replace $.browser dependent event handler attachment with jQuery and fix bad js escape
    
    [PR#5312](https://github.com/ManageIQ/manageiq/pull/5312)
    fixes 2 bugs:
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1278456
    https://bugzilla.redhat.com/show_bug.cgi?id=1278459
    
    clean cherry pick
    
    See merge request !410

 app/views/vm_common/console_vmrc.html.haml    | 10 ++++++----
 vendor/assets/javascripts/jquery-1.8.3.min.js |  2 ++
 2 files changed, 8 insertions(+), 4 deletions(-)

Comment 9 Ramesh A 2015-11-19 14:03:08 UTC
Good to go.  Verified and working fine in 5.5.0.11-rc1.20151117182049_653c0d4

Comment 11 errata-xmlrpc 2015-12-08 13:44:42 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2015:2551