Bug 1278772

Summary: Empty brightness indicator
Product: [Fedora] Fedora Reporter: Laurentiu Pancescu <lpancescu>
Component: xfce4-power-managerAssignee: Mukundan Ragavan <nonamedotc>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: 23CC: christoph.wickert, lpancescu, nonamedotc, woiling
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: xfce4-power-manager-1.5.2-4.fc23 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-02-15 02:51:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Screenshot of brightness indicator in XFCE
none
xfce4-power-manager log none

Description Laurentiu Pancescu 2015-11-06 11:40:25 UTC
Created attachment 1090632 [details]
Screenshot of brightness indicator in XFCE

Description of problem:
When I'm adjusting the display brightness (the screen backlight) using the keyboard, XFCE displays a progress bar, indicating the current intensity. In Fedora 23, the progress bar seems to have a zero width, and the "sun" icon is also missing (see the attached screenshot).

Version-Release number of selected component (if applicable):
1.5.2-1.fc23

How reproducible:
Always (I tried on two different netbook models)

Steps to Reproduce:
1. Use the keyboard to adjust the backlight
2.
3.

Actual results:
Empty OSD (on-screen display)

Expected results:
Progress bar indicating where the current brightness is, between min and max.

Additional info:
Please note that adjusting the brightness works, only the XFCE indicator is empty (so it's just a minor annoyance).  This works properly in Fedora 22, apparently using the same kernel 4.2.5.  Here are the kernel brightness values:
$ grep . /sys/class/backlight/acpi_video0/*
/sys/class/backlight/acpi_video0/actual_brightness:6
/sys/class/backlight/acpi_video0/bl_power:0
/sys/class/backlight/acpi_video0/brightness:6
grep: /sys/class/backlight/acpi_video0/device: Is a directory
/sys/class/backlight/acpi_video0/max_brightness:8
grep: /sys/class/backlight/acpi_video0/power: Is a directory
grep: /sys/class/backlight/acpi_video0/subsystem: Is a directory
/sys/class/backlight/acpi_video0/type:firmware

Comment 1 Mukundan Ragavan 2015-11-06 12:39:31 UTC
I have noticed this myself and have been meaning to file an upstream bug report about it ...

I will file this upstream (finally) later today.

Comment 2 Laurentiu Pancescu 2015-12-09 07:24:52 UTC
Created attachment 1103804 [details]
xfce4-power-manager log

I attached a debug log from xfce4-power-manager, covering startup and changing the brightness via the keyboard. I guess the empty OSD is caused by two different issues:

- not finding the xfpm-brightness-lcd icon in the Fedora or Adwaita themes (this icon can be found under /usr/share/icons/hicolor/*/status/xfpm-brightness-lcd.png under Fedora 22, can't check Fedora 23 right now)

- missing method GetMaxBrightness from org.freedesktop.UPower.KbdBacklight (this should exist, according to upower upstream documentation)

http://upower.freedesktop.org/docs/KbdBacklight.html#KbdBacklight.GetMaxBrightness

Comment 3 Woi 2015-12-25 11:05:36 UTC
Just updated from Fedora 22 to Fedora 23 and bumped into this issue.

$ cat /etc/os-release |grep PRETTY
PRETTY_NAME="Fedora 23 (Twenty Three)"
$ find /usr/share/icons/hicolor/ -iname xfpm-brightness*
$

Comment 4 Mukundan Ragavan 2015-12-29 00:11:52 UTC
Can you folks try this build?

https://koji.fedoraproject.org/koji/taskinfo?taskID=12228975

Comment 5 Woi 2015-12-29 13:14:25 UTC
(In reply to Mukundan Ragavan from comment #4)
> Can you folks try this build?
> 
> https://koji.fedoraproject.org/koji/taskinfo?taskID=12228975

Thanks for the build.

$ sudo dnf install -q -y https://kojipkgs.fedoraproject.org//work/tasks/8978/12228978/xfce4-power-manager-1.5.2-2.fc23.x86_64.rpm
$ xfce4-power-manager
$ killall xfce4-power-manager
$ xfce4-power-manager

Works for me.

PS: Just saw the --restart option of xfce4-power-manager

Comment 6 Laurentiu Pancescu 2015-12-30 09:29:21 UTC
I tried the i686 version yesterday evening, and it seems to work fine. The slider is displayed correctly while adjusting the brightness, and things like screen blanking and switching from AC to battery are handled just as before.  I didn't notice anything unusual in the few hours I tested it.

Thank you, Mukundan, for taking the time to build a fixed package!  With no reaction from upstream, I didn't have much hope of this being addressed soon, and certainly not before 2016 (I was thinking about waiting until at least mid-January before asking if you would consider incorporating my proposed patch directly into Fedora).

Comment 7 Woi 2016-02-02 16:14:59 UTC
Hey Mukundan,

any news when this bugfix will be available in fedora repos? currently the fixed RPM is not available anymore:

$ sudo dnf install https://kojipkgs.fedoraproject.org//work/tasks/8978/12228978/xfce4-power-manager-1.5.2-2.fc23.i686.rpm
Last metadata expiration check performed 2:52:37 ago on Tue Feb  2 14:20:27 2016.
Status code: 404 for https://kojipkgs.fedoraproject.org//work/tasks/8978/12228978/xfce4-power-manager-1.5.2-2.fc23.i686.rpm
[kathy@zim ~]$

Comment 8 Mukundan Ragavan 2016-02-04 00:16:07 UTC
I was hoping for a new upstream release. But it is probably worth to push an update. I will push an update in a day or two ...

Comment 9 Mukundan Ragavan 2016-02-04 00:35:10 UTC
(In reply to Woi from comment #7)
> Hey Mukundan,
> 
> any news when this bugfix will be available in fedora repos? currently the
> fixed RPM is not available anymore:
> 
> $ sudo dnf install
> https://kojipkgs.fedoraproject.org//work/tasks/8978/12228978/xfce4-power-
> manager-1.5.2-2.fc23.i686.rpm
> Last metadata expiration check performed 2:52:37 ago on Tue Feb  2 14:20:27
> 2016.
> Status code: 404 for
> https://kojipkgs.fedoraproject.org//work/tasks/8978/12228978/xfce4-power-
> manager-1.5.2-2.fc23.i686.rpm
> [kathy@zim ~]$

Temporarily - here is a build

http://koji.fedoraproject.org/koji/taskinfo?taskID=12823855

Comment 10 Woi 2016-02-04 01:24:28 UTC
(In reply to Mukundan Ragavan from comment #9)
> (In reply to Woi from comment #7)
[...]
> Temporarily - here is a build

Thanks a lot, that's lovely :) In return I asked upstream for a release: https://bugzilla.xfce.org/show_bug.cgi?id=12292#c7

Comment 11 Woi 2016-02-08 14:28:12 UTC
(In reply to Woi from comment #10)
[...]
> In return I asked upstream for a release:
> https://bugzilla.xfce.org/show_bug.cgi?id=12292#c7

Since there was no reaction upstream so far, I created a new bug:
https://bugzilla.xfce.org/show_bug.cgi?id=12438
Maybe no one looks on already closed bugs (And I'm not allowed to reopen it)

Comment 12 Fedora Update System 2016-02-09 01:06:49 UTC
xfce4-power-manager-1.5.2-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-0a7fdc205b

Comment 13 Mukundan Ragavan 2016-02-09 01:08:35 UTC
(In reply to Woi from comment #11)
> (In reply to Woi from comment #10)
> [...]
> > In return I asked upstream for a release:
> > https://bugzilla.xfce.org/show_bug.cgi?id=12292#c7
> 
> Since there was no reaction upstream so far, I created a new bug:
> https://bugzilla.xfce.org/show_bug.cgi?id=12438
> Maybe no one looks on already closed bugs (And I'm not allowed to reopen it)

Thanks for the upstream report.

I have pushed an update anyway. Please add karma.

Comment 14 Woi 2016-02-09 16:14:02 UTC
Karma added. Thanks for your support.

Comment 15 Fedora Update System 2016-02-09 22:26:24 UTC
xfce4-power-manager-1.5.2-4.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-0a7fdc205b

Comment 16 Fedora Update System 2016-02-15 02:51:07 UTC
xfce4-power-manager-1.5.2-4.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.