Bug 1279233

Summary: [REGENERATE JAVA SDK] No auto-completion option for scheduling policy name under cluster object
Product: [oVirt] ovirt-engine-sdk-java Reporter: Juan Hernández <juan.hernandez>
Component: CoreAssignee: Juan Hernández <juan.hernandez>
Status: CLOSED CURRENTRELEASE QA Contact: Gonza <grafuls>
Severity: medium Docs Contact:
Priority: low    
Version: 3.6.0.2CC: bugs, dfediuck, grafuls, mgoldboi, ncredi, oourfali, pstehlik
Target Milestone: ovirt-3.6.5Keywords: Automation
Target Release: 3.6.5.0Flags: rule-engine: ovirt-3.6.z+
rule-engine: planning_ack+
juan.hernandez: devel_ack+
pstehlik: testing_ack+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-engine-sdk-java-3.6.5.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1279159 Environment:
Last Closed: 2016-04-21 14:40:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Infra RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1279159    
Bug Blocks:    

Description Juan Hernández 2015-11-08 19:04:34 UTC 
+++ This bug was initially created as a clone of Bug #1279159 +++

Description of problem:
There is no 'name' attribute under scheduling policy object, when trying to add cluster, only scheduling-policy-policy, which is not compatible with other APIs

Version-Release number of selected component (if applicable):
rhevm-cli-3.5.0.6-1.el6ev.noarch
rhevm-cli-3.6.0.0-1.el6ev.noarch (this bug should be cloned to 3.6 as well)

How reproducible:
100%

Steps to Reproduce:
1.Add cluster in CLI with auto-completion options
2.
3.

Actual results:
scheduling-policy-policy exists, but incompatible with other APIs

Expected results:
scheduling-policy-name should exist

Additional info:

existing options under cluster:
'comment', 'ha_reservation', 'scheduling_policy-thresholds-duration', 'memory_policy-overcommit-percent', 'version-minor', 'data_center-id', 'scheduling_policy-id', 'correlation_id', 'expect', 'parent-datacenter-name', 'scheduling_policy-properties-property', 'fencing_policy-enabled', 'version-major', 'scheduling_policy-policy', 'scheduling_policy-thresholds-high', 'ksm-enabled', 'fencing_policy-skip_if_connectivity_broken-enabled', 'fencing_policy-skip_if_sd_active-enabled', 'ballooning_enabled', 'tunnel_migration', 'management_network-id', 'data_center-name', 'threads_as_cores', 'description', 'memory_policy-transparent_hugepages-enabled', 'display-proxy', 'gluster_service', 'parent-datacenter-identifier', 'management_network-name', 'fencing_policy-skip_if_connectivity_broken-threshold', 'error_handling-on_error', 'scheduling_policy-thresholds-low', 'name', 'cpu-id', 'maintenance_reason_required', 'virt_service', 'cpu-architecture', 'trusted_service', 'ksm-merge_across_nodes'

--- Additional comment from Oved Ourfali on 2015-11-08 04:08:49 EST ---

Juan, is that infra or sla?

--- Additional comment from Juan Hernández on 2015-11-08 13:41:31 EST ---

Initially it is infra. All CLI issues are infra as no other team takes care of the CLI.

Note however that in this particular case this will probably be caused by an incorrect description of the cluster "add" operation in the RSDL metadata. In that case the fix will require a change in the engine, and then a regeneration of the Python SDK, as the CLI extracts this information from the Python SDK. This means that eventually this bug will be moved or cloned to the RestAPI component. That moved or cloned bug will then be "sla".

--- Additional comment from Juan Hernández on 2015-11-08 13:58:18 EST ---

In order to fix this we need to change the RestAPI RSDL metadata. Then the Python SDK will need to be regenerated. The CLI doesn't need any change.
Comment 1 Red Hat Bugzilla Rules Engine 2015-11-08 23:06:06 UTC 
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.
Comment 2 Sandro Bonazzola 2015-12-23 13:43:05 UTC 
oVirt 3.6.2 RC1 has been released for testing, moving to ON_QA
Comment 3 Gonza 2016-02-04 11:52:04 UTC 
Tested with:
ovirt-engine-cli-3.6.0.2-1.el6.noarch
ovirt-engine-sdk-java-3.6.2.0-1.el6.noarch.rpm

name property has not been added to SchedulingPolicy object on api and --scheduling_policy-name parameter is not available on cli.

# curl https://raw.githubusercontent.com/oVirt/ovirt-engine-sdk-java/3.6.2.0/sdk/src/main/java/org/ovirt/engine/sdk/decorators/Clusters.java | sed -n '129,+6p' -
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0     *    [cluster.memory_policy.transparent_hugepages.enabled]
     *    [cluster.scheduling_policy.policy]
     *    [cluster.scheduling_policy.thresholds.low]
     *    [cluster.scheduling_policy.thresholds.high]
     *    [cluster.scheduling_policy.thresholds.duration]
     *    [cluster.scheduling_policy.id]
     *    [cluster.scheduling_policy.properties.property]


from 'help add cluster'
...
    * [--scheduling_policy-policy: string]
    * [--scheduling_policy-thresholds-low: int]
    * [--scheduling_policy-thresholds-high: int]
    * [--scheduling_policy-thresholds-duration: int]
    * [--scheduling_policy-id: string]
    * [--scheduling_policy-properties-property: collection]
      {
        [property.name: string]
        [property.value: string]
      }
...


# add cluster scheduling_policy-
scheduling_policy-id                   scheduling_policy-properties-property  scheduling_policy-thresholds-high      
scheduling_policy-policy               scheduling_policy-thresholds-duration  scheduling_policy-thresholds-low
Comment 4 Red Hat Bugzilla Rules Engine 2016-02-04 11:52:08 UTC 
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.
Comment 6 Gonza 2016-02-22 17:43:23 UTC 
Verified with:
ovirt-engine-sdk-java.noarch 0:3.6.3.1-0.1.20160211.gitcbd6036.el6                                                                                                                                               

From: https://gerrit.ovirt.org/gitweb?p=ovirt-engine-sdk-java.git;a=blob_plain;f=sdk/src/main/java/org/ovirt/engine/sdk/decorators/Clusters.java;h=f65121afa5cf335053d8cd6 

There doesn't seem to be any reference to:
*    [cluster.scheduling_policy.name]
Comment 7 Red Hat Bugzilla Rules Engine 2016-02-22 17:43:30 UTC 
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.
Comment 8 Gonza 2016-04-11 07:25:51 UTC 
Verified with:
rhevm-cli-3.6.2.0-1.el6ev.noarch

# add cluster scheduling_policy-<TAB><TAB>
scheduling_policy-id                   scheduling_policy-policy               scheduling_policy-thresholds-duration  scheduling_policy-thresholds-low       
scheduling_policy-name                 scheduling_policy-properties-property  scheduling_policy-thresholds-high
Comment 9 Gonza 2016-04-11 07:27:21 UTC 
rhevm-sdk-java-3.6.5.0-1.el6ev.noarch