Bug 1279326

Summary: In windows OS & firefox brower,Window.Location.replace(url) would stop System to execute Command, and would not catch any error info.But other OS like firefox in linux would not happen like that.
Product: [oVirt] ovirt-engine Reporter: BeiWen <43409338>
Component: Build.GWTAssignee: Vojtech Szocs <vszocs>
Status: CLOSED NOTABUG QA Contact: Pavel Stehlik <pstehlik>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 3.4.4CC: 43409338, bugs, didi, ecohen, lveyde, rmartins, sbonazzo, stirabos
Target Milestone: ---Flags: rule-engine: planning_ack?
rule-engine: devel_ack?
rule-engine: testing_ack?
Target Release: ---   
Hardware: x86_64   
OS: Windows   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-11-10 14:53:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description BeiWen 2015-11-09 08:03:46 UTC 
Description of problem:
I want to redirct the page when ovirt admin logout, so I add :Window.Location.replace("/test.html") in ApplicationPlaceManager.java as below:
 @Override
    public void revealDefaultPlace() {
        PlaceRequest pr = getDefaultPlace();
        if (pr == null) {
            //Window.Location.replace("/test.html"); //$NON-NLS-1$
        } else {
            revealPlace(pr);
        }
    }
or in LoginModel.java\BaseApplicationInit.java etc.
It can achieve to redirect by chrome,IE and firefox in Linux, and would execute LogoutUserCommand to clean user session,Then at firefox in Windows no matter which version, it could redirect but would not execute LogoutUserCommand, so I can log into System by previous URL without password. 
How can I redirect URL when logout?Is there any config files for this? I could not find it, thanks a lot :)

Version-Release number of selected component (if applicable):
3.4.5

How reproducible:
yes

Steps to Reproduce:
1.update code:ApplicationPlaceManager.java
 public void revealDefaultPlace() {
        PlaceRequest pr = getDefaultPlace();
        if (pr == null) {
            //Window.Location.replace("/test.html"); //$NON-NLS-1$
        } else {
            revealPlace(pr);
        }
    }
2.login system and logout
3.input previous url like :xxxxxx/ovirt-engine/webadmin/?locale=zh_CN#vms
and can redirect.

Actual results:
redirect into vm page.

Expected results:
redirect into login page.

Additional info:
Comment 1 BeiWen 2015-11-09 08:24:36 UTC 
Window.Location.replace is from com.google.gwt.user.client.Window
Comment 2 Yaniv Kaul 2015-11-10 10:40:11 UTC 
Hi, did you try to ask this question on the user mailing list? It doesn't look like a bug to me.
Comment 3 Einav Cohen 2015-11-10 14:53:43 UTC 
(In reply to Yaniv Kaul from comment #2)
> Hi, did you try to ask this question on the user mailing list? It doesn't
> look like a bug to me.

correct. this is an attempt to modify the code, this isn't an issue for bugzilla, but for devel mailing list / gerrit (in case you want to send a patch). thanks.
Comment 4 BeiWen 2015-11-12 05:42:04 UTC 
(In reply to Einav Cohen from comment #3)
> (In reply to Yaniv Kaul from comment #2)
> > Hi, did you try to ask this question on the user mailing list? It doesn't
> > look like a bug to me.
> 
> correct. this is an attempt to modify the code, this isn't an issue for
> bugzilla, but for devel mailing list / gerrit (in case you want to
> send a patch). thanks.

Thanks :)