Bug 1280343

Summary:	Review Request: perl-Text-Bidi - Unicode bidirectional algorithm using libfribidi
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Petr Šabata <psabata>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, psabata
Target Milestone:	---	Flags:	psabata: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Text-Bidi-2.11-1.fc24	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-11-16 15:14:30 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Pisar 2015-11-11 14:21:13 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Text-Bidi/perl-Text-Bidi.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Text-Bidi/perl-Text-Bidi-2.11-1.fc24.src.rpm
Description:
This Perl module provides basic support for the Unicode bidirectional (Bidi)
text algorithm, for displaying text consisting of both left-to-right and
right-to-left written languages (such as Hebrew and Arabic.) It does so via
a SWIG interface file to the libfribidi library.

Fedora Account System Username: ppisar

Comment 1 Petr Pisar 2015-11-13 07:44:36 UTC

I updated to package. After discussion with upstream, I install the misc/bidi file into urxvt plugin directory and I package it into a sub-package.

Comment 2 Petr Šabata 2015-11-13 13:30:53 UTC

* Since you chose the pkgconfig() approach, the build dependency on
  fribidi-devel seems rather pointless.

* Data::Dumper, and version are only used by the disabled t/ucd.t test.
  You can drop these build deps for now.

* I don't think the urxvt subpackage strictly requires the base package
  in this case and were it me, I would drop this dependency.
  If you decide to do this, don't forget to add the license text to the
  subpackage as well.

* The package doesn't build in mock.

Comment 3 Upstream Release Monitoring 2015-11-13 13:37:36 UTC

psabata's scratch build of perl-Text-Bidi-2.11-1.fc24.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11819387

Comment 4 Petr Šabata 2015-11-13 13:58:55 UTC

(In reply to Petr Šabata from comment #2)
> * The package doesn't build in mock.

Correction -- sometimes it does.  It's just unpredictable.
It could have something to do with the parallel build.

Comment 5 Petr Pisar 2015-11-16 12:44:11 UTC

I implemented all the changes. I kept parallel built so far.

Comment 6 Petr Šabata 2015-11-16 13:37:08 UTC

Acking all the changes.

Comment 7 Gwyn Ciesla 2015-11-16 14:29:18 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-Text-Bidi

Comment 8 Petr Pisar 2015-11-16 15:14:30 UTC

Thank you for the review and the repository.