Bug 1280423

Summary: RHCI Deployment Wizard allows user to provide empty hostnames
Product: Red Hat Quickstart Cloud Installer Reporter: bmorriso
Component: WebUIAssignee: Dylan Murray <dymurray>
Status: VERIFIED --- QA Contact: Dave Johnson <dajohnso>
Severity: low Docs Contact:
Priority: unspecified    
Version: 1.0CC: dymurray, jmatthew
Target Milestone: TP2Keywords: Triaged
Target Release: 1.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description bmorriso 2015-11-11 17:25:35 UTC
Description of problem:
When creating a new RHCI deployment with RHEV, the wizard allows a user to provide a blank hostname for the rhev-m and rhev-h hosts. 


Version-Release number of selected component (if applicable):
RHCI-6.0-RHEL-7-20151104.t.0-RHCI-x86_64-dvd1.iso

How reproducible:
always

Steps to Reproduce:
1. Create a new RHCI deployment that will install RHEV. 
2. On wizard page 2B, select a server to be used for rhev-m.
3. In the name field that pops up, delete the auto-generated hostname and leave the field blank. 
4. Click next and repeat the same steps on page 2C.

Actual results:
Blank hostnames are allowed.

Expected results:
UI displays an error and requires the user to not leave those fields blank. 

Additional info:

Comment 1 Antonin Pagac 2015-11-27 09:50:54 UTC
Also checking for invalid characters in the hostnames should be implemented.

Comment 2 Dylan Murray 2016-01-04 17:33:53 UTC
Blank host names and invalid characters will gray out the next button and the associated tab so that the user cannot advance without a valid host name.

Comment 3 Dylan Murray 2016-01-11 15:47:00 UTC
PR: https://github.com/fusor/fusor/pull/596

Comment 4 Antonin Pagac 2016-01-15 11:34:24 UTC
Verified.

Errors are now correctly displayed bellow the cell.
See the Next button issue: https://bugzilla.redhat.com/show_bug.cgi?id=1298890

RHCI-6.0-RHEL-7-20160114.t.0-RHCI-x86_64-dvd1.iso