Bug 1281450

Summary: stonith_admin strips description from fence agents' metadata
Product: Red Hat Enterprise Linux 7 Reporter: Tomas Jelinek <tojeline>
Component: pacemakerAssignee: Klaus Wenninger <kwenning>
Status: CLOSED ERRATA QA Contact: cluster-qe <cluster-qe>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.2CC: cluster-maint, ivlnka, kgaillot, phagara
Target Milestone: rc   
Target Release: 7.3   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: pacemaker-1.1.15-1.2c148ac.git.el7 Doc Type: No Doc Update
Doc Text:
undefined
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-11-03 18:56:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1304771    
Bug Blocks: 1262001    

Description Tomas Jelinek 2015-11-12 14:51:18 UTC
Description of problem:
When displaying fence agent's metadata using stonith_admin, text contained in longdesc and shortdesc tags is removed.


Version-Release number of selected component (if applicable):
pacemaker-1.1.13-10.el7.x86_64


How reproducible:
always, easily


Steps to Reproduce:
1. stonith_admin -M -a fence_xvm
2. fence_xvm -o metadata
3. compare 1 and 2


Actual results:
[root@rh71-node1:~]# stonith_admin -M -a fence_xvm | head
<resource-agent name="fence_xvm" shortdesc="Fence agent for virtual machines">
  <longdesc>
  </longdesc>
  <parameters>
    <parameter name="debug">
      <getopt mixed="-d"/>
      <content type="boolean"/>
      <shortdesc lang="en">
      </shortdesc>
    </parameter>


Expected results:
Description from the original metadata is not removed.


Additional info:
[root@rh71-node1:~]# fence_xvm -o metadata | head
<?xml version="1.0" ?>
<resource-agent name="fence_xvm" shortdesc="Fence agent for virtual machines">
<longdesc>fence_xvm is an I/O Fencing agent which can be used withvirtual machines.</longdesc>
<parameters>
        <parameter name="debug">
                <getopt mixed="-d" />
                <content type="boolean" />
                <shortdesc lang="en">Specify (stdin) or increment (command line) debug level</shortdesc>
        </parameter>
        <parameter name="ip_family">

Comment 1 Klaus Wenninger 2015-11-26 14:36:54 UTC
The report doesn't explicitely state that it is working as expected 
with the upstream master as of now even if the commit comments
don't point to the fix at the first sight.

Comment 2 Klaus Wenninger 2015-12-01 19:07:24 UTC
The following upstream commit fixes the problem:

https://github.com/ClusterLabs/pacemaker/commit/524c4d67099ecceaa7c7b26d5b4c0b3e1f8c59af

Comment 4 Mike McCune 2016-03-28 22:54:17 UTC
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

Comment 6 Patrik Hagara 2016-08-22 11:39:22 UTC
Confirmed fixed in pacemaker-1.1.15-9.el7.x86_64

Before the fix:

> [root@virt-247 ~]# rpm -q pacemaker
> pacemaker-1.1.13-10.el7_2.4.x86_64
> [root@virt-247 ~]# stonith_admin -M -a fence_xvm | head
> <resource-agent name="fence_xvm" shortdesc="Fence agent for virtual machines">
>   <longdesc>
>   </longdesc>
>   <parameters>
>     <parameter name="debug">
>       <getopt mixed="-d"/>
>       <content type="boolean"/>
>       <shortdesc lang="en">
>       </shortdesc>
>     </parameter>
> [root@virt-247 ~]# fence_xvm -o metadata | head
> <?xml version="1.0" ?>
> <resource-agent name="fence_xvm" shortdesc="Fence agent for virtual machines">
> <longdesc>fence_xvm is an I/O Fencing agent which can be used withvirtual machines.</longdesc>
> <parameters>
> 	<parameter name="debug">
> 		<getopt mixed="-d" />
> 		<content type="boolean" />
> 		<shortdesc lang="en">Specify (stdin) or increment (command line) debug level</shortdesc>
> 	</parameter>
> 	<parameter name="ip_family">


After the fix:

> [root@virt-138 ~]# rpm -q pacemaker
> pacemaker-1.1.15-9.el7.x86_64
> [root@virt-138 ~]# stonith_admin -M -a fence_xvm | head
> <resource-agent name="fence_xvm" shortdesc="Fence agent for virtual machines">
>   <longdesc>
>     fence_xvm is an I/O Fencing agent which can be used withvirtual machines.
>   </longdesc>
>   <parameters>
>     <parameter name="debug">
>       <getopt mixed="-d"/>
>       <content type="boolean"/>
>       <shortdesc lang="en">
>         Specify (stdin) or increment (command line) debug level
> [root@virt-138 ~]# fence_xvm -o metadata | head
> <?xml version="1.0" ?>
> <resource-agent name="fence_xvm" shortdesc="Fence agent for virtual machines">
> <longdesc>fence_xvm is an I/O Fencing agent which can be used withvirtual machines.</longdesc>
> <parameters>
> 	<parameter name="debug">
> 		<getopt mixed="-d" />
> 		<content type="boolean" />
> 		<shortdesc lang="en">Specify (stdin) or increment (command line) debug level</shortdesc>
> 	</parameter>
> 	<parameter name="ip_family">


stonith_admin no longer strips fence agent long description metadata. Marking verified.

Comment 8 errata-xmlrpc 2016-11-03 18:56:33 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2578.html