Bug 1281887

Summary: SSA of templates blocked.
Product: Red Hat CloudForms Management Engine Reporter: Rich Oliveri <roliveri>
Component: SmartState AnalysisAssignee: Rich Oliveri <roliveri>
Status: CLOSED ERRATA QA Contact: Taras Lehinevych <tlehinev>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 5.5.0CC: cpelland, dajohnso, jhardy, obarenbo, simaishi
Target Milestone: GA   
Target Release: 5.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.5.0.11 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-12-08 13:47:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Rich Oliveri 2015-11-13 17:24:21 UTC
Description of problem:
Definition of new validate_smartstate_analysis methods will prevent scanning of templates.


Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. Select a template under a provider that supports SSA
2. Try to perform SSA
3. 

Actual results:
SSA option not available.


Expected results:
SSA option available.


Additional info:

Comment 3 CFME Bot 2015-11-13 21:41:54 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/2f2e19b0973cf3e65d8f6bc0884587dc27ab3cc5

commit 2f2e19b0973cf3e65d8f6bc0884587dc27ab3cc5
Author:     Richard Oliveri <roliveri>
AuthorDate: Fri Nov 13 14:37:18 2015 -0500
Commit:     Richard Oliveri <roliveri>
CommitDate: Fri Nov 13 14:37:18 2015 -0500

    Ensure validate_smartstate_analysis is defined for templates.
    
    By default, validate_smartstate_analysis will return false.
    So, we must ensure that the default method is overridden for all
    supported types - VMs and Templates.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1281887

 app/models/manageiq/providers/amazon/cloud_manager/template.rb        | 4 ++++
 app/models/manageiq/providers/cloud_manager/vm.rb                     | 4 ----
 app/models/manageiq/providers/openstack/cloud_manager/template.rb     | 4 ++++
 app/models/manageiq/providers/redhat/infra_manager/vm.rb              | 4 ----
 .../providers/redhat/infra_manager/vm_or_template_shared/scanning.rb  | 4 ++++
 app/models/manageiq/providers/vmware/infra_manager/vm.rb              | 4 ----
 .../providers/vmware/infra_manager/vm_or_template_shared/scanning.rb  | 4 ++++
 7 files changed, 16 insertions(+), 12 deletions(-)

Comment 4 CFME Bot 2015-11-16 21:18:58 UTC
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=919e5b55e6adcedcec1b1956e8ad894487feef30

commit 919e5b55e6adcedcec1b1956e8ad894487feef30
Author:     Richard Oliveri <roliveri>
AuthorDate: Fri Nov 13 14:37:18 2015 -0500
Commit:     Richard Oliveri <roliveri>
CommitDate: Fri Nov 13 17:26:35 2015 -0500

    Ensure validate_smartstate_analysis is defined for templates.
    
    By default, validate_smartstate_analysis will return false.
    So, we must ensure that the default method is overridden for all
    supported types - VMs and Templates.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1281887

 app/models/manageiq/providers/amazon/cloud_manager/template.rb        | 4 ++++
 app/models/manageiq/providers/cloud_manager/vm.rb                     | 4 ----
 app/models/manageiq/providers/openstack/cloud_manager/template.rb     | 4 ++++
 app/models/manageiq/providers/redhat/infra_manager/vm.rb              | 4 ----
 .../providers/redhat/infra_manager/vm_or_template_shared/scanning.rb  | 4 ++++
 app/models/manageiq/providers/vmware/infra_manager/vm.rb              | 4 ----
 .../providers/vmware/infra_manager/vm_or_template_shared/scanning.rb  | 4 ++++
 7 files changed, 16 insertions(+), 12 deletions(-)

Comment 5 CFME Bot 2015-11-16 21:19:49 UTC
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=7bc0ec069a92119cb05957b2e6365eaa189c918e

commit 7bc0ec069a92119cb05957b2e6365eaa189c918e
Merge: a5652ef 919e5b5
Author:     Oleg Barenboim <obarenbo>
AuthorDate: Mon Nov 16 10:15:56 2015 -0500
Commit:     Oleg Barenboim <obarenbo>
CommitDate: Mon Nov 16 10:15:56 2015 -0500

    Merge branch 'validate_smartstate_fix_55z' into '5.5.z'
    
    Ensure validate_smartstate_analysis is defined for templates.
    
    By default, validate_smartstate_analysis will return false.
    So, we must ensure that the default method is overridden for all
    supported types - VMs and Templates.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1281887
    
    Upstream PR: https://github.com/ManageIQ/manageiq/pull/5439
    Clean cherry-pick.
    
    
    See merge request !457

 app/models/manageiq/providers/amazon/cloud_manager/template.rb        | 4 ++++
 app/models/manageiq/providers/cloud_manager/vm.rb                     | 4 ----
 app/models/manageiq/providers/openstack/cloud_manager/template.rb     | 4 ++++
 app/models/manageiq/providers/redhat/infra_manager/vm.rb              | 4 ----
 .../providers/redhat/infra_manager/vm_or_template_shared/scanning.rb  | 4 ++++
 app/models/manageiq/providers/vmware/infra_manager/vm.rb              | 4 ----
 .../providers/vmware/infra_manager/vm_or_template_shared/scanning.rb  | 4 ++++
 7 files changed, 16 insertions(+), 12 deletions(-)

Comment 6 Taras Lehinevych 2015-11-19 17:03:15 UTC
Verified fixed in version 5.5.0.11

Comment 8 errata-xmlrpc 2015-12-08 13:47:24 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2015:2551