Bug 1282004

Summary: GSL 2.1 support
Product: [Fedora] Fedora Reporter: Orion Poplawski <orion>
Component: orsaAssignee: Zbigniew Jędrzejewski-Szmek <zbyszek>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: dakingun, mmahut, rakesh.pandit, xjakub, zbyszek
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: orsa-0.7.0-35.fc24 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-11-25 05:42:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1276893    

Description Orion Poplawski 2015-11-14 05:08:43 UTC
Description of problem:

I'm working to update gsl to 2.1 in Fedora which has a number of API changes.  orsa fails with:

../../../src/liborsa/orsa_orbit_gsl.cc: In function 'int orsa::least_sq_df(const gsl_vector*, void*, gsl_matrix*)':
../../../src/liborsa/orsa_orbit_gsl.cc:1006:40: warning: format '%i' expects argument of type 'int', but argument 3 has type 'size_t {aka long unsigned int}' [-Wformat=]
   i,j,result,abserr,gsl_vector_get(v,j));
                                        ^
../../../src/liborsa/orsa_orbit_gsl.cc:1006:40: warning: format '%i' expects argument of type 'int', but argument 4 has type 'size_t {aka long unsigned int}' [-Wformat=]
../../../src/liborsa/orsa_orbit_gsl.cc: In function 'void orsa::OrbitDifferentialCorrectionsLeastSquares(orsa::OrbitWithCovarianceMatrixGSL&, const std::vector<orsa::Observation>&)':
../../../src/liborsa/orsa_orbit_gsl.cc:1105:24: error: 'struct gsl_multifit_fdfsolver' has no member named 'J'
  gsl_multifit_covar(s->J,0.0,covar);
                        ^
../../../src/liborsa/orsa_orbit_gsl.cc:1116:29: error: 'struct gsl_multifit_fdfsolver' has no member named 'J'
       gsl_multifit_covar(s->J,0.0,par.covar);
                             ^
../../../src/liborsa/orsa_orbit_gsl.cc:1122:27: error: 'struct gsl_multifit_fdfsolver' has no member named 'J'
     gsl_multifit_covar(s->J,0.0,covar);
                           ^

orsa upstream appears to be pretty much dead to me, so I suspect this will have to be handled in Fedora.  I don't know if debian has already ported but may be worth a check.

Comment 1 Zbigniew Jędrzejewski-Szmek 2015-11-24 22:01:38 UTC
Those first two look like a simple %i → %zi change, but the rest might be more complicated. Unfortunately Debian gave up on orsa is 2009 or so.

Comment 2 Orion Poplawski 2015-11-24 22:06:33 UTC
You might want to look at the patch for LabPlot in git master - similar errors.

Comment 3 Zbigniew Jędrzejewski-Szmek 2015-11-25 05:42:35 UTC
Should be fixed in rawhide (cd2f093a8f) to compile with both new and old gsl. Just rebuild whenever you push GSL 2.x.