Bug 1282084
| Summary: | Python3 port of python-flask-admin | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sebastian Dyroff <fedora> | ||||||
| Component: | python-flask-admin | Assignee: | Python Maintainers <python-maint> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 24 | CC: | fedora, jberan, lbalhar, pviktori, python-maint, tflink | ||||||
| Target Milestone: | --- | Flags: | lbalhar:
needinfo-
|
||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | python-flask-admin-1.2.0-3.fc23 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2016-04-19 19:24:35 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1285816, 1312032 | ||||||||
| Attachments: |
|
||||||||
I suspect the package's maintainer might not be getting notifications from this bug, so I've contacted him directly. python-flask-admin-1.2.0-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-136c2b771c python-flask-admin-1.2.0-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-136c2b771c This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle. Changing version to '24'. More information and reason for this action is here: https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase python-flask-admin-1.2.0-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. Hi Petr, please, could you check? It looks that there is still remaining Python 2 vs Python 3 dependency issue not reflected in this bug that should be kept open. Indeed, there's a bug on lines 79-80 of the specfile: http://pkgs.fedoraproject.org/cgit/rpms/python-flask-admin.git/tree/python-flask-admin.spec#n79 The Python version in current Fedoras is is 3.5, so the `%{__grep} -v python3.4` won't match anything, and py3 files are included in the py2 package. Instead of hardcoding `3.4`, you should use %python3_version. Hi Sebastian, please could you fix your attached patch according to Petr Viktorin's guidance? Thank you. Created attachment 1219688 [details]
Fix language files for python version
I created a new patch against master that should fix the issue.
I see a few other problems:
- There is a file python-flask-admin-1.4.2-1.fc25.src.rpm in the repo
- the language specific files are not in %lang
Maybe it is possible to use the %find_lang macro for the lang files
Hello, I created a Pagure PR that provides new version of python-flask-admin and fixes the Python 2 vs Python 3 dependency issue: https://src.fedoraproject.org/rpms/python-flask-admin/pull-request/1 Please, may I ask to review and rebuild? |
Created attachment 1094192 [details] patch againts the master spec Upstream seems to support python3. I added a python3 subpackage to the original spec file. Please have a look, especially look into the translations grep sed magic to generate the lang files. I also changed the LICENSE file to %license