Bug 1282640
| Summary: | Review Request: lastpass-cli - Command line interface to LastPass.com | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom Prince <tom.prince> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | gbailey, kparal, package-review, zbyszek |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | zbyszek:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-02-28 12:11:47 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Tom Prince
2015-11-16 23:49:20 UTC
There are just incorrect-fsf-address RPM lint errors. Upstream PR: https://github.com/lastpass/lastpass-cli/pull/131 You can probably replace the make line with %make_build. ...and the two make install lines with %make_install install-docs. rm -rf $RPM_BUILD_ROOT is not needed and is not recommended [http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag]. %defattr is not needed [http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions]. Use %{_mandir} for the path, and do not hardcode the compression: /usr/share/man/man1/lpass.1.gz → %{_mandir}/man1/lpass.1.* The changelog has an empty entry at the bottom. Either fill it in or remove. Thanks for the review. > You can probably replace the make line with %make_build. Doing this results in the debuginfo package not having sources. I'm open to other suggestions. I've addressed the rest of the comments: Spec URL: https://tomprince.fedorapeople.org/lastpass-cli.spec SRPM URL: https://tomprince.fedorapeople.org/lastpass-cli-0.7.0-2.fc23.src.rpm Copr Build: https://copr.fedoraproject.org/coprs/tomprince/Personal/build/145205/ - license is OK (GPLv2)
- license file is present, %license is used
- latest version
- builds and install OK
- the executable runs fine
- provides / requires look sane
- no scriptlets needed or present
Rpmlint
-------
Checking: lastpass-cli-0.7.0-2.fc24.x86_64.rpm
lastpass-cli-debuginfo-0.7.0-2.fc24.x86_64.rpm
lastpass-cli-0.7.0-2.fc24.src.rpm
lastpass-cli.x86_64: E: incorrect-fsf-address /usr/share/licenses/lastpass-cli/COPYING
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/cmd-rm.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/cmd-generate.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/agent.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/cmd-sync.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/http.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/cipher.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/blob.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/endpoints-login.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/xml.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/cmd-login.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/lpass.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/endpoints.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/cmd-export.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/cmd.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/config.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/clipboard.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/cmd-duplicate.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/endpoints-share.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/terminal.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/password.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/process.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/session.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/cmd-logout.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/cmd-edit.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/cmd-show.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/cmd-ls.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/kdf.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/util.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/cmd-share.c
lastpass-cli-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/lastpass-cli-0.7.0/upload-queue.c
3 packages and 0 specfiles checked; 31 errors, 0 warnings.
The license is already fixed upstream.
Package is APPROVED.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/lastpass-cli lastpass-cli-0.7.0-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-14a09f31e0 lastpass-cli-0.7.0-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-83dfc07d0e lastpass-cli-0.7.0-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update lastpass-cli' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-83dfc07d0e lastpass-cli-0.7.0-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update lastpass-cli' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14a09f31e0 lastpass-cli-0.7.0-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. lastpass-cli-0.7.0-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. lastpass-cli-0.7.0-3.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-26d445497a lastpass-cli-0.8.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-3e614e9a35 lastpass-cli-0.8.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-3e614e9a35 lastpass-cli-0.8.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. The package is in Fedora, I believe this should be closed. |