Bug 1282911

Petr, wrong flag (fedora_requires_release_note)?

Thanks.

dfateyev's scratch build of perl-Crypt-Salsa20-0.03-2.fc20.denf.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11892278

Adjusted BRs fully as requested in a previous review, small cleanup.

Spec path: http://www.fateyev.com/RPMS/Fedora22/perl-Crypt-Salsa20.spec

Rawhide scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=11892279

I'll assume this is for Fedora only.

* Missing a BR, as already pointed out in the other current reviews:
  - perl(integer), used in lib/Crypt/Salsa20.pm (lots)

* strict and warnings are used in the Makefile.PL, too.
  You may want to list them in the top block, for consistence.
  Well, this depends on your style preference...

* Drop META.json from %doc, it's of no use to your end users.

* Package the license text using the %license macro.

* If you really don't need EPEL compatibility, you can:
  1) ignore the abovementioned coreutils & findutils point.
  2) Add a 6.76+ version dependency constraint to EU::MM.
  3) Generate the Makefile with `NO_PACKLIST=1'.
  This will allow you to drop line 46.

* The Group tag is optional, too.

dfateyev's scratch build of perl-Crypt-Salsa20-0.03-2.fc20.denf.src.rpm for epel7 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11894175

On the contrary, I'm planning to maintain it in EPEL too. Thanks for the detailed clarifications, anyway.

- Added perl(integer) to BR (thought that all concerned Perl versions had it so omitted it initially);
- Dropped META.json.

EL6 doesn't support %license tag so I didn't used it. The Group tag is also kept for more EPEL adaptivity.

Spec path: http://www.fateyev.com/RPMS/Fedora22/perl-Crypt-Salsa20.spec

Rawhide scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=11894191

(In reply to Denis Fateyev from comment #7)
> On the contrary, I'm planning to maintain it in EPEL too. Thanks for the
> detailed clarifications, anyway.
> 
> - Added perl(integer) to BR (thought that all concerned Perl versions had it
> so omitted it initially);

You never know what the future might bring.  And even if it's very unlikely, just listing everything is more consistent and, in a way, easier.

> - Dropped META.json.

Ack.

> EL6 doesn't support %license tag so I didn't used it. The Group tag is also
> kept for more EPEL adaptivity.

Regarding the Group tag: Ack.

The %license macro is mandatory in Fedora, though.

I use the following `trick' in my packages.  There might be a better way but this works fine:

%{!?_licensedir:%global license %%doc}
%license LICENSE
%doc Changes README

dfateyev's scratch build of perl-Crypt-Salsa20-0.03-2.fc20.denf.src.rpm for dist-6E-epel completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11910647

- Added "%license" tag (according https://fedoraproject.org/wiki/EPEL:Packaging#The_.25license_tag since I believe there is a doubled percent sign above);
- Added AUTOMATED_TESTING variable for more thorough testing plan;

Spec path: http://www.fateyev.com/RPMS/Fedora22/perl-Crypt-Salsa20.spec

Rawhide scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=11910666

(In reply to Denis Fateyev from comment #10)
> - Added "%license" tag (according
> https://fedoraproject.org/wiki/EPEL:Packaging#The_.25license_tag since I
> believe there is a doubled percent sign above);

This works too.  Good to know.

> - Added AUTOMATED_TESTING variable for more thorough testing plan;

Ack.


Well, all good now.  Approving.

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-Crypt-Salsa20

Any updates?  Pushed and built?

There is a bug in Bodhi: https://github.com/fedora-infra/bodhi/issues/707
I've been waiting for the fix, otherwise I can't push it.

Ah, I see.  I prefer the CLI utility :)

Me too, but it failed the last time I used it so I suspected there was also a bug. I'll try with cli one more time, anyway.

perl-Crypt-Salsa20-0.03-2.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-eadb1907e7

perl-Crypt-Salsa20-0.03-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-2ec055bb1f

perl-Crypt-Salsa20-0.03-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-7fa2974150

perl-Crypt-Salsa20-0.03-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-df5b8d7cc1

perl-Crypt-Salsa20-0.03-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'yum --enablerepo=epel-testing update perl-Crypt-Salsa20'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-2ec055bb1f

perl-Crypt-Salsa20-0.03-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'yum --enablerepo=epel-testing update perl-Crypt-Salsa20'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-eadb1907e7

perl-Crypt-Salsa20-0.03-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update perl-Crypt-Salsa20'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-7fa2974150

perl-Crypt-Salsa20-0.03-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update perl-Crypt-Salsa20'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-df5b8d7cc1

perl-Crypt-Salsa20-0.03-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

perl-Crypt-Salsa20-0.03-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

perl-Crypt-Salsa20-0.03-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

perl-Crypt-Salsa20-0.03-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.