Bug 1282914
Summary: | Review Request: perl-Lingua-Translit - Transliterates text between writing systems | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Denis Fateyev <denis> |
Component: | Package Review | Assignee: | Jitka Plesnikova <jplesnik> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | jplesnik, package-review, perl-devel |
Target Milestone: | --- | Flags: | jplesnik:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-12-06 01:24:07 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1284461 | ||
Bug Blocks: |
Description
Denis Fateyev
2015-11-17 19:27:05 UTC
jplesnik's scratch build of perl-Lingua-Translit-0.22-1.fc24.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11891179 Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed $ rpm -qp --requires perl-Lingua-Translit-0.22-1.fc24.noarch.rpm | sort | uniq -c 1 /usr/bin/perl 1 perl(:MODULE_COMPAT_5.22.0) 1 perl(:VERSION) >= 5.8.0 1 perl(Carp) 1 perl(Encode) 1 perl(Exporter) 1 perl(Getopt::Long) 1 perl(Lingua::Translit) 1 perl(Lingua::Translit::Tables) 1 perl(strict) 1 perl(utf8) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -qp --provides perl-Lingua-Translit-0.22-1.fc24.noarch.rpm | sort | uniq -c 1 perl(Lingua::Translit) = 0.22 1 perl(Lingua::Translit::Tables) = 0.10 1 perl-Lingua-Translit = 0.22-1.fc24 Binary provides are Ok. $ rpmlint ./perl-Lingua-Translit* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Rpmlint is ok BuildRequires FIX: Please add BRs: - perl(Exporter) - Lingua-Translit-0.22/lib/Lingua/Translit/Tables.pm - line 74 - perl(utf8) - Lingua-Translit-0.22/lib/Lingua/Translit/Tables.pm - line 12 and tests - make - spec file - line 38, 44, 52 - coreutils - spec file - line 46, 47, 56 - findutils - spec file - line 46, 47 FIX: Replace variable PERL_INSTALL_ROOT obsoleted with DESTDIR name in %install. TODO: Remove the deleting empty directories in %install section. This is default behavior. Please correct all 'FIX' issues and consider fixing 'TODO' items and provide new spec file. Thanks for the review, Jitka.
> - make - spec file - line 38, 44, 52
> - coreutils - spec file - line 46, 47, 56
> - findutils - spec file - line 46, 47
Aren't they populated in build environment automatically? I believe I've seen once a list of packages which aren't required in BR, but surprisingly I can't find it right now.
All dependencies should be listed due to the latest version of the packaging guidelines. The list which you mention was removed. For more info: https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_2 https://fedorahosted.org/fpc/ticket/497 dfateyev's scratch build of perl-Lingua-Translit-0.22-2.fc20.denf.src.rpm for f23 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11891896 Thanks, didn't know about these recent changes in guidelines. Fixed BuildRequires, improved source path, fixed another small details mentioned. Spec path: http://www.fateyev.com/RPMS/Fedora22/perl-Lingua-Translit.spec Rawhide scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=11891891 It looks good now. Approved Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-Lingua-Translit perl-Lingua-Translit-0.22-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-b89a8a7be7 perl-Lingua-Translit-0.22-2.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-456947b83d perl-Lingua-Translit-0.22-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-cd0119af4f perl-Lingua-Translit-0.22-2.el5 has been submitted as an update to Fedora EPEL 5. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-b025075c9c perl-Lingua-Translit-0.22-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update perl-Lingua-Translit' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-b89a8a7be7 perl-Lingua-Translit-0.22-2.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update perl-Lingua-Translit' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-b025075c9c perl-Lingua-Translit-0.22-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update perl-Lingua-Translit' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-456947b83d perl-Lingua-Translit-0.22-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update perl-Lingua-Translit' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-5858d1d314 perl-Lingua-Translit-0.22-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update perl-Lingua-Translit' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-cd0119af4f perl-Lingua-Translit-0.23-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8bc29ecc34 perl-Lingua-Translit-0.23-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-7baefb67c1 perl-Lingua-Translit-0.23-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-23a8155f8a perl-Lingua-Translit-0.23-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-538f171889 perl-Lingua-Translit-0.23-1.el5 has been submitted as an update to Fedora EPEL 5. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-f8acd7e341 Updates for this submission are obsoleted with RHBZ#1284461 (0.23 release came shortly after 0.22 considered here). perl-Lingua-Translit-0.23-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update perl-Lingua-Translit' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-538f171889 perl-Lingua-Translit-0.23-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update perl-Lingua-Translit' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-23a8155f8a perl-Lingua-Translit-0.23-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update perl-Lingua-Translit' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8bc29ecc34 perl-Lingua-Translit-0.23-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update perl-Lingua-Translit' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-7baefb67c1 perl-Lingua-Translit-0.23-1.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update perl-Lingua-Translit' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-f8acd7e341 perl-Lingua-Translit-0.23-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. perl-Lingua-Translit-0.23-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. perl-Lingua-Translit-0.23-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. perl-Lingua-Translit-0.23-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. perl-Lingua-Translit-0.23-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |