Bug 1282945
Summary: | /run should not be a volume | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 7 | Reporter: | Scott Dodson <sdodson> |
Component: | rhel-server-container | Assignee: | Frantisek Kluknavsky <fkluknav> |
Status: | CLOSED ERRATA | QA Contact: | atomic-bugs <atomic-bugs> |
Severity: | high | Docs Contact: | |
Priority: | unspecified | ||
Version: | 7.2 | CC: | bparees, dwalsh, jpazdziora, mjenner, rrajaram, sct, walters |
Target Milestone: | rc | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-12-08 14:04:05 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1282733 |
Description
Scott Dodson
2015-11-17 21:10:11 UTC
Yes we should not have /run as a volume in the base image. We are working on other solutions for handling systemd in the container. --tmpfs patch is moving along and dockerhooks are both better solutions. (In reply to Daniel Walsh from comment #4) > Yes we should not have /run as a volume in the base image. Trouble is, *not* having it breaks things. As one specific example, on rhel7/rhel-7.1-24, we don't have /run and so we get a broken fs symlink for an important sub-directory: # docker run --rm -ti rhel7/rhel:7.1-24 ls -l /var/lock lrwxrwxrwx. 1 root root 11 Oct 30 07:05 /var/lock -> ../run/lock See https://bugzilla.redhat.com/show_bug.cgi?id=1105616 "Base image is missing several files from /run/*" > We are working > on other solutions for handling systemd in the container. --tmpfs patch is > moving along and dockerhooks are both better solutions. In that case the image should just create /run/lock. Not use volume mounts. Docker has specified that /run on the image should be populated by the tools installed, for example "yum install httpd" will create /run/httpd on the image. The secrets patch should not create a volume, but will create a mount point /run/secrets I believe. But docker build will not save the content in this directory to an image. OK -- then yes, this definitely shouldn't be a volume in the base image. Do we know why the /run volume was added? Any expected consequences of reverting that change? https://bugzilla.redhat.com/show_bug.cgi?id=1235969 Primary expected consequence would be systemd not running. (Of course the user can fix it easily when running the container. I meant, systemd not running out of box.) OK; for now I think it's far preferable to require the user does a manual VOLUME /run for the special case of running systemd, than to be unable to persist anything in /run. It would be nice if we could handle this automatically in the future, but for now should we not just revert the VOLUME in the base image? # docker inspect registry.access.stage.redhat.com/rhel7.2:7.2-38 <snip> "Image": "", "Volumes": null, Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHEA-2015-2575.html |