Bug 128305
Summary: | xscreensaver trips log updates which spin up my disk | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Pete Zaitcev <zaitcev> |
Component: | xorg-x11 | Assignee: | Mike A. Harris <mharris> |
Status: | CLOSED RAWHIDE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 2 | CC: | xgl-maint |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | i386 | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2004-10-14 18:24:03 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 130887 |
Description
Pete Zaitcev
2004-07-21 16:07:59 UTC
Thanks Pete. I'll change the default verbosity for that line to one notch higher so it doesn't normally appear in the logfile. I've never personally found the GetModeLine log entries useful ever, so they wont be missed by me at least. ;o) This is rather important for laptops, so I'm marking this as a FC3 TARGET bug, but it'll probably get put into FC2, FC1 erratum also. XFree86-VidModeExtension displays these messages in the log file if the verbosity level is >1 (see .../Xserver/Xext/xf86vmode.c). For it to not show up in the log file, the verbosity tests need to be >3. Unfortunately, this test is currently hard coded everywhere in the file. It should be changed to use a #define, which can be placed at the top of the file: #define DEFAULT_XF86VIDMODE_VERBOSITY 3 and then each test: if (xf86GetVerbosity() > 1) { could be changed to: if (xf86GetVerbosity() > DEFAULT_XF86VIDMODE_VERBOSITY) { This should also be submitted upstream for consideration. I'll take resonsibility for this one. Reassigning to myself. I've modified the Xvidmode extension to only log these messages when (xf86GetVerbosity() > DEFAULT_XF86VIDMODE_VERBOSITY), and set DEFAULT_XF86VIDMODE_VERBOSITY==3 to 3, which is the default X server log file verbosity level. This should cause all vidmode extension messages to continue to be written to the console et al., but not to the log file. I have submitted my patch upstream at: http://freedesktop.org/bugzilla/show_bug.cgi?id=1552 The xorg-x11-6.8.1-5 build contains this enhancement, and is currently building in our buildsystem. Please test the new build out once it is available and provide feedback on the testing results. There should no longer be vidmode related logfile messages unless you change the logfile verbosity to 4 or greater. Setting RFE status to "MODIFIED" state pending testing results. Once this has been tested, please set to "ASSIGNED" state with status update if problems occur, or set to "RAWHIDE" if the patch is confirmed to work. Thanks in advance for testing. Pete, does this look any better to you now? I am sorry, I haven't tested it yet, primarily because I received a laptop where the hard drive is not as noisy... Please close if it bothers you. Hi guys, We've had independant confirmation that the patch works for people. It's submitted upstream as well and should be the default in X11 6.9.0. Thanks. Setting status to "RAWHIDE" |