Bug 1283282

Summary: Screen contents gets cutoff when toolbar wraps
Product: Red Hat CloudForms Management Engine Reporter: Eric Winchell <ewinchel>
Component: UI - OPSAssignee: Dávid Halász <dhalasz>
Status: CLOSED ERRATA QA Contact: Milan Falešník <mfalesni>
Severity: high Docs Contact:
Priority: high    
Version: 5.5.0CC: cpelland, dclarizi, hkataria, jhardy, mpovolny, obarenbo, simaishi
Target Milestone: GA   
Target Release: 5.5.0   
Hardware: Unspecified   
OS: All   
Whiteboard:
Fixed In Version: 5.5.0.12 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-12-08 13:48:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
cropped contents none

Description Eric Winchell 2015-11-18 15:23:11 UTC
Description of problem:

The toolbar div is only calculated to have a height of 44 pixels. When the toolbar wraps (as it does often on the VM Summary Screens with Custom button groups), the contents at the bottom of the screen becomes cut off.

Version-Release number of selected component (if applicable):


How reproducible:

100%


Steps to Reproduce:
1. Go to any VM Summary Screen
2.
3.

Actual results:

Contents at bottom of screen is cut off

Expected results:

Contents should not be cut off.

Additional info:

Comment 2 Eric Winchell 2015-11-18 15:28:06 UTC
Created attachment 1096128 [details]
cropped contents

Comment 4 CFME Bot 2015-11-18 16:50:25 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/bba8626b3dd0896fec89b223c65199c98b6e89dc

commit bba8626b3dd0896fec89b223c65199c98b6e89dc
Author:     Dávid Halász <dhalasz>
AuthorDate: Wed Nov 18 13:32:01 2015 +0100
Commit:     Dávid Halász <dhalasz>
CommitDate: Wed Nov 18 17:04:52 2015 +0100

    Implemented dynamic main content height based on toolbar & footer
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1283282

 app/assets/javascripts/miq_application.js        | 17 +++++++++++++++++
 app/assets/stylesheets/patternfly_overrides.scss |  8 ++++----
 app/helpers/application_helper.rb                | 20 --------------------
 app/presenters/explorer_presenter.rb             |  2 +-
 app/views/layouts/_content.html.haml             |  8 ++++----
 5 files changed, 26 insertions(+), 29 deletions(-)

Comment 5 CFME Bot 2015-11-19 17:11:31 UTC
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=58e598643ec82b85e4bd8d9df90a12f74d29601f

commit 58e598643ec82b85e4bd8d9df90a12f74d29601f
Author:     Dávid Halász <dhalasz>
AuthorDate: Wed Nov 18 13:32:01 2015 +0100
Commit:     Dávid Halász <dhalasz>
CommitDate: Thu Nov 19 17:12:00 2015 +0100

    Implemented dynamic main content height based on toolbar & footer
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1283282
    Clean cherry pick from: https://github.com/ManageIQ/manageiq/pull/5493
    (cherry picked from commit bba8626b3dd0896fec89b223c65199c98b6e89dc)

 app/assets/javascripts/miq_application.js        | 17 +++++++++++++++++
 app/assets/stylesheets/patternfly_overrides.scss |  8 ++++----
 app/helpers/application_helper.rb                | 20 --------------------
 app/presenters/explorer_presenter.rb             |  2 +-
 app/views/layouts/_content.html.haml             |  8 ++++----
 5 files changed, 26 insertions(+), 29 deletions(-)

Comment 6 CFME Bot 2015-11-19 17:11:40 UTC
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=b1e7a28db4640e16aa564f828d7381a2a5e5a9e3

commit b1e7a28db4640e16aa564f828d7381a2a5e5a9e3
Merge: edb914f 58e5986
Author:     Dan Clarizio <dclarizi>
AuthorDate: Thu Nov 19 12:03:54 2015 -0500
Commit:     Dan Clarizio <dclarizi>
CommitDate: Thu Nov 19 12:03:54 2015 -0500

    Merge branch 'bz-1283282' into '5.5.z'
    
    Implemented dynamic main content height based on toolbar & footer
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1283282
    Clean cherry pick from: https://github.com/ManageIQ/manageiq/pull/5493
    (cherry picked from commit bba8626b3dd0896fec89b223c65199c98b6e89dc)
    
    See merge request !504

 app/assets/javascripts/miq_application.js        | 17 +++++++++++++++++
 app/assets/stylesheets/patternfly_overrides.scss |  8 ++++----
 app/helpers/application_helper.rb                | 20 --------------------
 app/presenters/explorer_presenter.rb             |  2 +-
 app/views/layouts/_content.html.haml             |  8 ++++----
 5 files changed, 26 insertions(+), 29 deletions(-)

Comment 7 Milan Falešník 2015-11-26 11:33:10 UTC
I see no cutoff in 5.5.0.12.

Comment 9 errata-xmlrpc 2015-12-08 13:48:38 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2015:2551