Bug 1283434
| Summary: | libappindicator looks in CWD for an icon name and tries to use that first, confusion insues | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Cole Robinson <crobinso> |
| Component: | libappindicator | Assignee: | Eduardo Echeverria <echevemaster> |
| Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 23 | CC: | bazanluis20, echevemaster, pfpschneider |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-12-20 16:04:31 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
This message is a reminder that Fedora 23 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 23. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '23'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 23 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Fedora 23 changed to end-of-life (EOL) status on 2016-12-20. Fedora 23 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. This bug is still present in the current appindicator in Fedora 31. |
I maintain virt-manager, which will use libappindicator for its statusicon support, if libappindicator is installed. The appindicator is initialized like this: self.systray_icon = AppIndicator3.Indicator.new( "virt-manager", "virt-manager", AppIndicator3.IndicatorCategory.OTHER) The first "virt-manager" is the app name, the second "virt-manager" is the icon name. When running this on gnome-shell, libappindicator needs to fall back to using a traditional StatusIcon. However it has some weird logic for picking the icon to use; if (icon_name != NULL) { if (g_file_test(icon_name, G_FILE_TEST_EXISTS)) { gtk_status_icon_set_from_file(icon, icon_name); } else { gchar *longname = append_panel_icon_suffix(icon_name); if (longname != NULL && gtk_icon_theme_has_icon (icon_theme, longname)) { gtk_status_icon_set_from_icon_name(icon, longname); } else { gtk_status_icon_set_from_icon_name(icon, icon_name); } g_free(longname); } } The first thing it checks for is a file in CWD named $icon_name, and if so, tries to use that for the icon. So when I would try to test this when running it from virt-manager.git, which contains a python script named 'virt-manager', the statustray area would be empty (which is actually worse than a missing icon). I don't know what the purpose of the file_test is, maybe a test suite depends on it or something, but it definitely causes weird behavior. I figure it should check the icon_theme first, and at least perform some error checking on the icon file loading, it may not even be an image.