Bug 1283549

Summary: Dynflow tasks killed due to timeout should kill pulp task behind them
Product: Red Hat Satellite Reporter: Pavel Moravec <pmoravec>
Component: Tasks PluginAssignee: satellite6-bugs <satellite6-bugs>
Status: CLOSED WONTFIX QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 6.1.3Keywords: Triaged
Target Milestone: Unspecified   
Target Release: Unused   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-09-04 18:00:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Pavel Moravec 2015-11-19 09:28:03 UTC
Description of problem:
Assume capsule sync (just one example, the problem is little more general) timeouts after (default) 12 hours. Relevant dynflow task is stopped with an error, particular sub-task in dynflow is skipped. BUT external task (here pulp task) is not cancelled.

Also the pulp task (and at the end gofer task to remove the json file in /var/lib/gofer/messaging/pending/katelloplugin dir) needs to be cancelled. Otherwise:

1) End-user gets wrong information the task is finished (with whatever output)
2) An attempt to run the same task again might cause concurrent pulp tasks running twice - something that I expect can cause errors


Version-Release number of selected component (if applicable):
Sat 6.1.3


How reproducible:
100%


Steps to Reproduce:
(one particular reproducer for capsule sync is provided - other equivalent for e.g. package install can be found easily)
1. Decrease sync timeout from 12 hours to say 1 minute (Administer -> Settings -> Katello -> pulp_sync_node_action_finish_timeout)
2. Start capsule sync that would take longer than the timeout
3. Wait until the task timeouts
4. Check pulp tasks and /var/lib/gofer/messaging/pending/katelloplugin directory.


Actual results:
pulp task will be stll running.
/var/lib/gofer/messaging/pending/katelloplugin dir would have the json file with the request to capsule sync


Expected results:
pulp task cancelled
/var/lib/gofer/messaging/pending/katelloplugin cleaned out


Additional info:

Comment 2 Bryan Kearney 2018-09-04 18:00:55 UTC
Thank you for your interest in Satellite 6. We have evaluated this request, and we do not expect this to be implemented in the product in the foreseeable future. We are therefore closing this out as WONTFIX. If you have any concerns about this, please feel free to contact Rich Jerrido or Bryan Kearney. Thank you.