Bug 1284406

Summary: [RFE] Add multiple-search paths for vdsm hooks
Product: [oVirt] vdsm Reporter: Fabian Deutsch <fdeutsch>
Component: RFEsAssignee: Yaniv Bronhaim <ybronhei>
Status: CLOSED WONTFIX QA Contact: Aleksei Slaikovskii <aslaikov>
Severity: medium Docs Contact:
Priority: medium    
Version: ---CC: bazulay, bugs, cshao, fdeutsch, gklein, huzhao, lsurette, mgoldboi, nsoffer, oourfali, pstehlik, srevivo, ybronhei, ycui, ykaul
Target Milestone: ---Keywords: FutureFeature
Target Release: ---Flags: sbonazzo: ovirt-4.1-
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-11-22 14:51:42 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Infra RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Fabian Deutsch 2015-11-23 09:28:58 UTC
Description of problem:
Currently vdsm is just looking in one directory for hooks.
To allow a better integration with Node (and other image based delivery models) it would be good if vdsm was looking in multiple locations for hooks.

i.e. the search order could be

1. /usr/libexec/vdsm/hooks/
2. /usr/lib/vdsm/hooks.d/  # See below, for vendor side (by default) enabled hooks
2. /etc/vdsm/hooks.d/  # For user enabled hooks


In addition it would be very useful, to separate the hook delivery from the hook enablement.
i.e. the hooks could be delivered in /usr/libexec/vdsm/hooks, but to enable them, a symlink needs to be placed into /usr/lib/vdsm/hooks.d/ or /etc/vdsm/hooks.d/.

Comment 1 Oved Ourfali 2016-01-27 06:35:02 UTC
Fabian - is that still relevant in next-gen node?

Comment 2 Fabian Deutsch 2016-01-27 11:12:05 UTC
Yes, it is _especially_ relevant for ngn.

Comment 3 Fabian Deutsch 2016-02-22 16:09:41 UTC
Any plans for this RFE?

Comment 4 Oved Ourfali 2016-02-24 11:24:08 UTC
(In reply to Fabian Deutsch from comment #3)
> Any plans for this RFE?

We will do our best to accomplish that in 4.0, but note that it might be pushed out eventually.

Comment 5 Yaniv Bronhaim 2016-11-22 14:51:42 UTC
Spoke with Fabian offline - there is no actual need for additional hook path folder right now. please re-open if the requirement is indeed needed