Bug 1284565

Summary: Review Request: nodejs-nan1 - Native Abstractions for Node.js
Product: [Fedora] Fedora Reporter: Tom Hughes <tom>
Component: Package ReviewAssignee: Jared Smith <jsmith.fedora>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: jsmith.fedora, package-review
Target Milestone: ---Flags: jsmith.fedora: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-11-24 19:06:01 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 956806    

Description Tom Hughes 2015-11-23 15:18:27 UTC
Spec URL: http://tomh.fedorapeople.org//nodejs-nan1.spec
SRPM URL: http://tomh.fedorapeople.org//nodejs-nan1-1.9.0-1.fc23.src.rpm

Description:
A header file filled with macro and utility goodness
for making add on development for Node.js easier across
versions 0.8, 0.10 and 0.11, and eventually 0.12.

Thanks to the crazy changes in V8 (and some in Node core),
keeping native add-on compiling happily across versions,
particularly 0.10 to 0.11/0.12, is a minor nightmare.
The goal of this project is to store all logic necessary
to develop native Node.js add-on without having to inspect
NODE_MODULE_VERSION and get yourself into a macro-tangle.

Comment 1 Upstream Release Monitoring 2015-11-23 15:20:29 UTC
tomh's scratch build of nodejs-nan1-1.9.0-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11953778

Comment 2 Jared Smith 2015-11-23 16:33:58 UTC
Package is approved.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT/X11 (BSD like)", "ISC", "*No copyright* MIT/X11 (BSD
     like)", "Unknown or generated".
[x]: Package does not own files or directories owned by other packages.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 71680 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: nodejs-nan1-1.9.0-1.fc24.noarch.rpm
          nodejs-nan1-1.9.0-1.fc24.src.rpm
nodejs-nan1.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-nan1.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-nan1.noarch: W: only-non-binary-in-usr-lib
nodejs-nan1.noarch: W: devel-file-in-non-devel-package /usr/lib/node_modules/nan@1/nan_new.h
nodejs-nan1.noarch: W: devel-file-in-non-devel-package /usr/lib/node_modules/nan@1/nan_implementation_12_inl.h
nodejs-nan1.noarch: W: devel-file-in-non-devel-package /usr/lib/node_modules/nan@1/nan_implementation_pre_12_inl.h
nodejs-nan1.noarch: W: devel-file-in-non-devel-package /usr/lib/node_modules/nan@1/nan.h
nodejs-nan1.noarch: W: devel-file-in-non-devel-package /usr/lib/node_modules/nan@1/nan_string_bytes.h
nodejs-nan1.src: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-nan1.src: W: spelling-error %description -l en_US js -> dis, ks, j
2 packages and 0 specfiles checked; 0 errors, 10 warnings.




Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
nodejs-nan1.noarch: W: invalid-url URL: https://github.com/nodejs/nan <urlopen error [Errno -3] Temporary failure in name resolution>
nodejs-nan1.noarch: W: only-non-binary-in-usr-lib
nodejs-nan1.noarch: W: devel-file-in-non-devel-package /usr/lib/node_modules/nan@1/nan.h
nodejs-nan1.noarch: W: devel-file-in-non-devel-package /usr/lib/node_modules/nan@1/nan_implementation_12_inl.h
nodejs-nan1.noarch: W: devel-file-in-non-devel-package /usr/lib/node_modules/nan@1/nan_implementation_pre_12_inl.h
nodejs-nan1.noarch: W: devel-file-in-non-devel-package /usr/lib/node_modules/nan@1/nan_string_bytes.h
nodejs-nan1.noarch: W: devel-file-in-non-devel-package /usr/lib/node_modules/nan@1/nan_new.h
1 packages and 0 specfiles checked; 0 errors, 7 warnings.



Requires
--------
nodejs-nan1 (rpmlib, GLIBC filtered):
    nodejs(engine)



Provides
--------
nodejs-nan1:
    nodejs-nan-devel
    nodejs-nan-static
    nodejs-nan1
    npm(nan)



Source checksums
----------------
https://registry.npmjs.org/nan/-/nan-1.9.0.tgz :
  CHECKSUM(SHA256) this package     : ad1b5130455d6894e894bd1c2177d8c29663dd77f11623af93c0f551c0128c0b
  CHECKSUM(SHA256) upstream package : ad1b5130455d6894e894bd1c2177d8c29663dd77f11623af93c0f551c0128c0b


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -b 1284565
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 3 Tom Hughes 2015-11-23 16:43:41 UTC
Thanks for the quick review!

Comment 4 Gwyn Ciesla 2015-11-23 18:12:27 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/nodejs-nan1