Bug 1284601

Summary:	Review Request: perl-Trace-Mask - Masking frames in stack traces
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Petr Šabata <psabata>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, psabata
Target Milestone:	---	Flags:	psabata: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Trace-Mask-0.000006-1.fc24	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-11-25 11:28:13 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1284482
Bug Blocks:

Description Petr Pisar 2015-11-23 16:07:46 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Trace-Mask/perl-Trace-Mask.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Trace-Mask/perl-Trace-Mask-0.000006-1.fc24.src.rpm
Description:
This is a specification packages can follow to define behaviors stack
tracers may choose to honor. If a module implements this specification than
any compliant stack tracer will render the stack trace as desired. This
package also provides some implementations (e.g. a Carp stack tracer).

Fedora Account System Username: ppisar

Comment 1 Petr Šabata 2015-11-24 15:00:13 UTC

* strict & warnings are used by the Makefile.PL, too.
  You may want to list them in the first BR block.

* Similarly, you may want to move the Try::Tiny BR to the `runtime block'.

* Just like Test::Stream, all the source files point to the Artistic license.
  Let upstream know.


No real issues.  Approving.

Comment 2 Gwyn Ciesla 2015-11-24 16:46:46 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-Trace-Mask

Comment 3 Petr Pisar 2015-11-25 11:28:13 UTC

Thank you for the review and the repository.