Bug 1284686

Per 6.3 planning, moving out non acked bugs to the backlog

Created redmine issue http://projects.theforeman.org/issues/18329 from this bug

*** Bug 1382002 has been marked as a duplicate of this bug. ***

*** Bug 1354337 has been marked as a duplicate of this bug. ***

This did not make the 1.15/3.5 cut. I am pushing this out to sat-backlog.

Moving this bug to POST for triage into Satellite 6 since the upstream issue http://projects.theforeman.org/issues/18329 has been resolved.

On satellite-6.3.0-19.0.beta.el7sat.noarch this fails due to https://bugzilla.redhat.com/show_bug.cgi?id=1497957

Christine, cold you please give me some background of the feature, as I didn't find much information on how it's meant to be used (and tested), namely:

-- Are there any prerequisites to the procedure, and does the script check if it has what it needs?
-- Is it supposed to stop services?
-- Can it be combined with other katello-backup subcommands?
-- How to restore from backup created by this feature?

Cheers

After working around the issue from 1497957:
~]# katello-backup --snapshot /var/tmp
Starting backup: 2017-10-04 04:44:07 -0400
Creating backup folder /var/tmp/katello-backup-20171004044409
Generating metadata ... 
Cannot create a temporary file: /var/tmp/scl3HIanE
Done.
Backing up config files... 
Done.
WARNING: This script will stop your services. Do you want to proceed(y/n)? y
Redirecting to /bin/systemctl stop foreman-tasks.service
Redirecting to /bin/systemctl stop httpd.service
Redirecting to /bin/systemctl stop pulp_celerybeat.service
Redirecting to /bin/systemctl stop pulp_streamer.service
Redirecting to /bin/systemctl stop pulp_resource_manager.service
Redirecting to /bin/systemctl stop pulp_workers.service
Redirecting to /bin/systemctl stop tomcat.service
Redirecting to /bin/systemctl stop postgresql.service
Redirecting to /bin/systemctl stop mongod.service
Creating pulp snapshot
  Volume group "rhel_sgi-uv20-01" has insufficient free space (0 extents): 512 required.
Failed 'lvcreate -npulp-snap -L2G -s /dev/mapper/rhel_sgi--uv20--01-root' with exit code 5
Cleaning up backup folder and starting any stopped services... 
/usr/share/ruby/fileutils.rb:125: warning: conflicting chdir during another chdir block
Redirecting to /bin/systemctl start mongod.service
Redirecting to /bin/systemctl start postgresql.service
Redirecting to /bin/systemctl start tomcat.service
Redirecting to /bin/systemctl start pulp_workers.service
Redirecting to /bin/systemctl start pulp_resource_manager.service
Redirecting to /bin/systemctl start pulp_streamer.service
Redirecting to /bin/systemctl start pulp_celerybeat.service
Redirecting to /bin/systemctl start httpd.service

Not sure why I get "Cannot create a temporary file: /var/tmp/scl3HIanE" and why it is needed. Obviously there is a prerequisite of having some free extents in a vg, but that should be documented at least in the script.

I'd like to be able to set the lv name for cases like:

Creating pulp snapshot
  Logical Volume "pulp-snap" already exists in volume group "rhel_sgi-uv20-01"
Failed 'lvcreate -npulp-snap -L2G -s /dev/mapper/rhel_sgi--uv20--01-root' with exit code 5
Cleaning up backup folder and starting any stopped services...

Seems like lvs are not cleaned up after failure

Moving to POST since upstream redmine is merged.

Hi Christine, could you please take a look at my questions from comment #13? Also I wonder what is the expected behavior of this feature on Capsule and what are the prerequisites to successful usage. 

I created a documentation bug for this feature in https://bugzilla.redhat.com/show_bug.cgi?id=1505890

(In reply to Peter Ondrejka from comment #13)
> On satellite-6.3.0-19.0.beta.el7sat.noarch this fails due to
> https://bugzilla.redhat.com/show_bug.cgi?id=1497957
> 
> Christine, cold you please give me some background of the feature, as I
> didn't find much information on how it's meant to be used (and tested),
> namely:
> 
> -- Are there any prerequisites to the procedure, and does the script check
> if it has what it needs?
Prerequisites are that the filesystem must be an LVM filesystem, and there must be enough space in the volume group in which to create the snapshot. It will fail the backup if these are not in place, giving a message with the exit codes.

> -- Is it supposed to stop services?
It must stop services, but it will only be momentarily. There is no way to do snapshots with online backup. The services will be down for the amount of time it takes to create the snapshot.

> -- Can it be combined with other katello-backup subcommands? 
Should be fine to do, except with online-backup.

> -- How to restore from backup created by this feature?
Same way you restore any other backup, #katello-restore /path/to/backup/folder

> 
> Cheers

@Evgeni - could you tell us if there are any more prerequisites to snapshots that I'm missing here?

If you would wake me at 2 am in the morning and ask me for requirements for working snapshots, you'd get the following:

* the system uses LVM for (at least) /var/lib/pulp, /var/lib/mongodb, /var/lib/pgsql
* the above mentioned points are preferably (but not necessarily) on different LVs
* there is sufficient free space (3×snapshot_size, 2G by default, = 6G) in the relevant VGs
  * if all three points are on VG1, it has to have 3×snapshot_size (2G by default, = 6G) free
  * if spread differently, the free space have to match too ;)
* the backup target is preferably not on a snapshoted LV, as this would mean you have to fit the whole backup into the snapshot, raising the snapshot space requirement by orders of magnitude

Need to add bypass of logical volume validation

Hello, checked again on snap 35,

-- snapshot backup performs as expected, the above error was due to lack of space on backup destination LV
-- snapshots seem to play well with other options (--incremental, --skip-pulp-content)
-- services are started after creating a snapshot as expected
-- restored from snapshot backups successfully 
-- checked both on server and capsule

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:0336